Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor songtag LRC handling #384

Merged
merged 30 commits into from
Nov 4, 2024
Merged

Refactor songtag LRC handling #384

merged 30 commits into from
Nov 4, 2024

Commits on Oct 31, 2024

  1. test(lib::songtag::lrc): add basic tests

    @hasezoey
    hasezoey committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    8572acf View commit details
    Browse the repository at this point in the history

  2. refactor(lib::songtag::lrc::Lyric): remove "lang_extension" field 

    as it is completely unused
    @hasezoey
    hasezoey committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    57a14d2 View commit details
    Browse the repository at this point in the history

  3. style(lib::songtag::lrc): add doc-comments and rename variables 

    fixup: rename variables
    @hasezoey
    hasezoey committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    8ca648a View commit details
    Browse the repository at this point in the history

  4. style(lib::songtag::lrc): remove unused regexes

    @hasezoey
    hasezoey committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    97fbd5d View commit details
    Browse the repository at this point in the history

  5. style(lib::songtag::lrc): inline "EOL" constant 

    as its only used once, all other places have it inlined already
    @hasezoey
    hasezoey committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    43caf81 View commit details
    Browse the repository at this point in the history

  6. test(lib::songtag::lrc): add test for printing as lrc

    @hasezoey
    hasezoey committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    e283f2b View commit details
    Browse the repository at this point in the history

  7. fix(lib::songtag::lrc::time_lrc): print the subsec millis instead of … 

    …the full millis

also no modulation for millis
    @hasezoey
    hasezoey committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    d93b508 View commit details
    Browse the repository at this point in the history

  8. feat(lib::utils): add "display_with" function 

    nested formatting without intermediate allocations!
    @hasezoey
    hasezoey committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    89b24d8 View commit details
    Browse the repository at this point in the history

  9. refactor(lib::songtag::lrc): format to LRC string with less intermedi… 

    …ate allocations
    @hasezoey
    hasezoey committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    ff9c5f1 View commit details
    Browse the repository at this point in the history

  10. refactor(lib::songtag::lrc::Lyric__merge_adjacent): get the item mut … 

    …instead of indexing
    @hasezoey
    hasezoey committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    189017d View commit details
    Browse the repository at this point in the history

  11. style(lib::songtag::lrc::Lyric::merge_adjacent): skip first element s… 

    …impler
    @hasezoey
    hasezoey committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    5419e69 View commit details
    Browse the repository at this point in the history

  12. refactor(lib::songtag::lrc::Caption::parse_line): do less searching

    @hasezoey
    hasezoey committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    f3932e3 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. refactor(lib::songtag::lrc::Caption::parse_time): do less searching 

    also no heap allocations
    @hasezoey
    hasezoey committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    c744b23 View commit details
    Browse the repository at this point in the history

  2. refactor(lib::songtag::lrc): refactor most parsing to return Options … 

    …instead of Result<_, ()>
    @hasezoey
    hasezoey committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    ab53dc9 View commit details
    Browse the repository at this point in the history

  3. refactor(lib::songtag::lrc::Lyric::from_str): reduce amount of alloca… 

    …tions and checking

also reverse "sort_by" variable names
    @hasezoey
    hasezoey committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    3a9da23 View commit details
    Browse the repository at this point in the history

  4. style(lib::track): use alias for "Lyrics" to lessen name confusion

    @hasezoey
    hasezoey committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    6010c7f View commit details
    Browse the repository at this point in the history

  5. style(lib::track::Track::process_tag): chain option

    @hasezoey
    hasezoey committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    841b527 View commit details
    Browse the repository at this point in the history

  6. refactor(tui::ui::components::tag_editor::view::Model::init_by_song):… 

    … less cloning for lyric frames
    @hasezoey
    hasezoey committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    92d00aa View commit details
    Browse the repository at this point in the history

  7. perf(lib::track::Track::set_lyric): replace index directly 

    instead of removing, shifting, shifting again and adding.
    @hasezoey
    hasezoey committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    2ebed2a View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2024

  1. test(lib::songtag::lrc): add test for "merge_adjacent"

    @hasezoey
    hasezoey committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    e31d6b1 View commit details
    Browse the repository at this point in the history

  2. test(lib::songtag::lrc): add test for "adjust_offset"

    @hasezoey
    hasezoey committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    b1e0f07 View commit details
    Browse the repository at this point in the history

  3. fix(lib::songtag::lrc::Lyric::get_index): change to not adjust time 

    Change so that "get_index" does not add 2seconds to the time, if it is still wanted, the caller should do it.
Also change input to be milliseconds
    @hasezoey
    hasezoey committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    458434f View commit details
    Browse the repository at this point in the history

  4. fix(lib::songtag::lrc::Lyric::adjust_offset): correctly add new offset 

    instead of inverting
    @hasezoey
    hasezoey committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    0bc7c34 View commit details
    Browse the repository at this point in the history

  5. refactor(lib::songtag::lrc::Lyric): dont cast, use "try_from"

    @hasezoey
    hasezoey committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    48a010a View commit details
    Browse the repository at this point in the history

  6. style(lib::songtag::lrc::Lyric::adjust_offset): use "if >" instead of… 

    … "match .cmp"
    @hasezoey
    hasezoey committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    936d670 View commit details
    Browse the repository at this point in the history

  7. test(lib::songtag::lrc): add test for "get_text"

    @hasezoey
    hasezoey committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    ec8f172 View commit details
    Browse the repository at this point in the history

  8. perf(lib::songtag::lrc::Lyric::get_text): less cloning

    @hasezoey
    hasezoey committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    5d839dd View commit details
    Browse the repository at this point in the history

  9. fix(tui::ui::components::lyric::lyric_update): base "no lyrics availa… 

    …ble" message on same value

instead of "on no lyric frames" and later use "parsed lyrics"
    @hasezoey
    hasezoey committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    d3b8f60 View commit details
    Browse the repository at this point in the history

  10. fix(lib::songtag::lrc::Lyric::get_text): use milliseconds directly 

    instead of getting seconds, then converting to milliseconds
    @hasezoey
    hasezoey committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    cc38521 View commit details
    Browse the repository at this point in the history

  11. style(lib::songtag::lrc::get_text): give a reason why a 2 second offs… 

    …et is used
    @hasezoey
    hasezoey committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    6649960 View commit details
    Browse the repository at this point in the history