Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

AP-1531 Zero-pad fixed-length binary fields #162

Merged
merged 8 commits into from
Aug 9, 2023
Merged

AP-1531 Zero-pad fixed-length binary fields #162

merged 8 commits into from
Aug 9, 2023

Conversation

Samira-El
Copy link
Contributor

Problem

pymysql-replication v0.41 has introduced a change in how binary type data is extracted
The data is now zero-padded.
julien-duponchelle/python-mysql-replication@ed4dd28

This breaks the integration tests and creates a discrepancy between the data extracted by parsing binlogs (log based) and that which is extracted by incremental/full table (ie by running select queries) because the select query trims any trailing zeros.

Need to fix this and create consistency so that we can upgrade to the new version of pymysql-replication.

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to PipelineWise?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • CI checks pass with my changes
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commit message/PR title starts with [AP-NNNN] (if applicable. AP-NNNN = JIRA ID)
  • Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

teaf-wise
teaf-wise previously approved these changes Jul 5, 2023
Copy link

@teaf-wise teaf-wise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

teaf-wise
teaf-wise previously approved these changes Aug 7, 2023
@Samira-El Samira-El merged commit 1b4861a into master Aug 9, 2023
7 checks passed
@Samira-El Samira-El deleted the AP-1531 branch August 9, 2023 13:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants