This repository has been archived by the owner on Sep 23, 2024. It is now read-only.
AP-1531 Zero-pad fixed-length binary fields #162
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
pymysql-replication v0.41 has introduced a change in how binary type data is extracted
The data is now zero-padded.
julien-duponchelle/python-mysql-replication@ed4dd28
This breaks the integration tests and creates a discrepancy between the data extracted by parsing binlogs (log based) and that which is extracted by incremental/full table (ie by running select queries) because the select query trims any trailing zeros.
Need to fix this and create consistency so that we can upgrade to the new version of pymysql-replication.
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to PipelineWise?
Put an
x
in the boxes that applyChecklist
setup.py
is an individual PR and not mixed with feature or bugfix PRs[AP-NNNN]
(if applicable. AP-NNNN = JIRA ID)AP-NNN
(if applicable. AP-NNN = JIRA ID)