Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP-1531 Zero-pad fixed-length binary fields #1123

Merged
merged 5 commits into from
Aug 11, 2023
Merged

AP-1531 Zero-pad fixed-length binary fields #1123

merged 5 commits into from
Aug 11, 2023

Conversation

Samira-El
Copy link
Contributor

@Samira-El Samira-El commented Jul 4, 2023

Problem

Same issue as transferwise/pipelinewise-tap-mysql#162

FastSync has been trimming trailing zeros from binary data, we need to stop doing that and make it consistent with other Singer replication methods

Proposed changes

stop trimming trailing zeros

Types of changes

What types of changes does your code introduce to PipelineWise?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • CI checks pass with my changes
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commit message/PR title starts with [AP-NNNN] (if applicable. AP-NNNN = JIRA ID)
  • Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

@Samira-El Samira-El temporarily deployed to github-pages July 4, 2023 16:26 — with GitHub Actions Inactive
@Samira-El Samira-El temporarily deployed to ci_tests July 4, 2023 16:26 — with GitHub Actions Inactive
@Samira-El Samira-El temporarily deployed to ci_tests July 4, 2023 16:26 — with GitHub Actions Inactive
@Samira-El Samira-El temporarily deployed to ci_tests July 4, 2023 16:26 — with GitHub Actions Inactive
@Samira-El Samira-El temporarily deployed to ci_tests July 4, 2023 16:26 — with GitHub Actions Inactive
@Samira-El Samira-El temporarily deployed to ci_tests July 4, 2023 16:26 — with GitHub Actions Inactive
@Samira-El Samira-El temporarily deployed to ci_tests July 4, 2023 16:26 — with GitHub Actions Inactive
@Samira-El Samira-El temporarily deployed to ci_tests August 10, 2023 16:44 — with GitHub Actions Inactive
@Samira-El Samira-El temporarily deployed to github-pages August 10, 2023 16:44 — with GitHub Actions Inactive
@Samira-El Samira-El temporarily deployed to ci_tests August 10, 2023 16:44 — with GitHub Actions Inactive
@Samira-El Samira-El temporarily deployed to ci_tests August 10, 2023 16:44 — with GitHub Actions Inactive
@Samira-El Samira-El temporarily deployed to ci_tests August 10, 2023 16:44 — with GitHub Actions Inactive
@Samira-El Samira-El temporarily deployed to ci_tests August 10, 2023 16:44 — with GitHub Actions Inactive
@Samira-El Samira-El temporarily deployed to ci_tests August 10, 2023 16:44 — with GitHub Actions Inactive
@Samira-El Samira-El removed the draft PR in progress label Aug 11, 2023
@Samira-El Samira-El merged commit b7c3b42 into master Aug 11, 2023
13 checks passed
@Samira-El Samira-El deleted the AP-1531 branch August 11, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants