Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong PFCP control flow during HSS Initiated Subscribed QoS Modification #346

Closed
RoadRunnr opened this issue Mar 19, 2021 · 0 comments · Fixed by #356
Closed

wrong PFCP control flow during HSS Initiated Subscribed QoS Modification #346

RoadRunnr opened this issue Mar 19, 2021 · 0 comments · Fixed by #356

Comments

@RoadRunnr
Copy link
Member

HSS Initiated Subscribed QoS Modification is defined in TS 23.401 clause 5.4.2.2 and updated for CUPS in TS 23.214 clause 6.3.1.7.

The resulting control flow should invoke a PFCP session modification only after the Update Bearer Response (step in 23.401) has been received.

We currently trigger a PFCP usage query on receiving the modification command and trigger another PFCP usage query when getting the Update Bearer Response. Since QoS is currently not supported, updating the bearers in the UPF is not needed, but the first usage query is not needed at all and the second query is only needed when the QoS settings have indeed been changed.

A race between the session termination when the update bearer procedure returns a failure and the first usage query causes random test case failures in pgw_suite.modify_bearer_command_congestion.

Failure is update bearer requests are rare, so this bug has only medium priority.

RoadRunnr added a commit that referenced this issue Apr 12, 2021
delay PFCP action till the Update Beares Response is known

fixes #346
RoadRunnr added a commit that referenced this issue Apr 12, 2021
delay PFCP action till the Update Beares Response is known

fixes #346
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant