-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor application split and with it also config handling #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoadRunnr
force-pushed
the
refactor/config
branch
4 times, most recently
from
April 7, 2021 10:17
2d5bfcc
to
3c193a3
Compare
RoadRunnr
force-pushed
the
refactor/config
branch
3 times, most recently
from
April 7, 2021 14:59
454cc69
to
b0dc6e0
Compare
The ultimate goal is not to modify the environment config in any way. However, converting all test cases from lists to maps would be a large effort. So, for the moment continue to accept proplists in place of maps and convert them.
Relex restriction on keys, permit arbitrary, unique keys.
The conversion from list to map takes care of that now.
RoadRunnr
force-pushed
the
refactor/config
branch
from
April 8, 2021 07:40
b0dc6e0
to
24404cc
Compare
Instead of converting the resulst to maps, have validation work on the converted map. Drop all functions that work directly on lists. Except the socket list. It will be converted separately.
Proplists are no longer used for config after validation. Support to return proplists from validation can therefore be removed.
In preparation of a more library like approach, move validation of the configuration elements into the modules that actually handle them.
Use ergw_core as API module and begin to move externally visible methods into it.
Application startup is move out of ergw_core into a new (old) ergw application. ergw_core is now only a library that needs to be initialized properly from the main app. ergw is responsible for reading and ypplying the configuration to ergw_core. This is the first step of untangling the root config from ergw_core. The test suites are currently broken and will be converted in the next steps.
Fixup remaining problems after refactoring and adjust config tests.
Remove config loader from ergw_core and add API functions to load the component configuration separately. Adjust the tests to test and use the new API functions.
RoadRunnr
force-pushed
the
refactor/config
branch
from
April 8, 2021 07:50
24404cc
to
3fd681a
Compare
test cases are failing in pgw_SUITEs |
vkatsuba
approved these changes
Apr 12, 2021
Instead of killing the runtime system, let the supervisor restart policy handle that.
Restict type check FOR KEY on config maps when the key is actually a name (and not an option name).
Note: configuring the meters is still disabled.
ergw is now a starte app, config is read from a config file in json or yaml format. For the momement, only ergw_core is configured. ergw_aaa config will come next.
* restore HTTP API function * restore HTTP API tests * change answers config in AAA subsection to proper K/V structure and update JSON configurations * restore sbi API test suite
Run all OTP version test to completion, regardless of other failures.
RoadRunnr
force-pushed
the
refactor/config
branch
from
April 12, 2021 11:28
62acb83
to
cab3698
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STATUS
Passes most tests suites. TODO are in state that the work can distributed across several developers (set TODOs)
CHANGES
TODOs