Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNS: add negative caching for empty responses #355

Merged
merged 1 commit into from
Apr 12, 2021
Merged

DNS: add negative caching for empty responses #355

merged 1 commit into from
Apr 12, 2021

Conversation

RoadRunnr
Copy link
Member

this is stacked on top of #354

vkatsuba
vkatsuba reviewed Apr 7, 2021
View reviewed changes
Copy link
Contributor

@vkatsuba vkatsuba left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need also cherry pick DNS: add negative caching for empty responses to some new branch which based on 2.8.9 release?

@RoadRunnr
Copy link
Member Author

Do we need also cherry pick DNS: add negative caching for empty responses to some new branch which based on 2.8.9 release?

I don't think that makes sense, let 2.8.x use the old cache and use the new one for master

@RoadRunnr RoadRunnr marked this pull request as ready for review April 12, 2021 11:48
@RoadRunnr RoadRunnr requested a review from a team as a code owner April 12, 2021 11:48
@RoadRunnr RoadRunnr merged commit 562ccce into master Apr 12, 2021
@RoadRunnr RoadRunnr deleted the feature/dns-enhancements branch April 12, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkatsuba vkatsuba vkatsuba approved these changes

@fholzhauser fholzhauser Awaiting requested review from fholzhauser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RoadRunnr @vkatsuba