Add .x resolution and --resolve command #130

philpennock · 2018-02-17T02:50:42Z

New persistent file, ~/.gimme/versions/known-versions.txt, which is
kept in sorted unique order
Add --resolve for handling version specifiers in a
normally-lightweight manner, where stdout gets the resolved version.
Handle NN.x (and NN.MM.x) as a version specifier, against the
known versions
Have the --known output be cached to disk; there's a cache bypass
mechanism (flag), and a cache age control environment variable.
Rework some cache handling stuff to be in cleaner functional
abstractions
Adds a _version_sort filter
Bug-fix for stable age using access-time not mod-time on darwin|*bsd

See the README updates for notes on interaction between --resolve and
git tag resolution, and how to avoid that.

Fixes #129
Resolves #110

philpennock · 2018-02-17T02:51:26Z

nb: I actually want to resolve this into master, but since it adds to the documentation added by #128 I've based the review diff off of that.

philpennock · 2018-02-17T03:03:43Z

~~Re travis build failures: I disbelieve that ./gimme -h can stall for 10 minutes, as a result of anything in this PR, or at all.~~ I was wrong, I messed up.

* New persistent file, `~/.gimme/versions/known-versions.txt`, which is kept in sorted unique order * Add `--resolve` for handling version specifiers in a normally-lightweight manner, where stdout gets the resolved version. * Handle `NN.x` (and `NN.MM.x`) as a version specifier, against the known versions * Have the `--known` output be cached to disk; there's a cache bypass mechanism (flag), and a cache age control environment variable. * Rework some cache handling stuff to be in cleaner functional abstractions * Adds a `_version_sort` filter * Bug-fix for stable age using access-time not mod-time on darwin|*bsd See the README updates for notes on interaction between `--resolve` and git tag resolution, and how to avoid that. Fixes #129 Resolves #110

1.1 1.10 1.2 is bad. 1.1 1.2 .. 1.9 1.10 is good.

philpennock · 2018-02-17T23:34:40Z

NB: Do not merge until #131 is approved and merged into this; GitHub handles stacked PRs very badly.

travis-ci/gimme#132 (comment) travis-ci/gimme#130

AlekSi

I don't know bash that well, so I mostly checked the documentation.

Thank you for working on this!

gimme

@@ -18,6 +18,8 @@
 #+        -f --force force - remove the existing go installation if present prior to install
 #+          -l --list list - list installed go versions and exit
 #+        -k --known known - list known go versions and exit
+#+    --force-known-update - when used with --known, ignores the cache and updates
+#+    -r --resolve resolve - resolve a version specifier to a version, show that and exit


README.md

@@ -164,7 +164,8 @@ versions and point Gimme at that instead.
 Invoke `gimme -k` or `gimme --known` to have Gimme report the versions which
 can be installed; invoking `gimme stable` installs the version which the Go
 Maintainers have declared to be stable.  Both of these involve making
-non-cached network requests to retrieve this information.
+network requests to retrieve this information, although the `--known` output
+is cached.  (Use `--force-update` to ignore the cache).


AlekSi · 2018-02-21T03:25:22Z

Does not work in Raspbian:

pi@raspberrypi:~/gimme $ bash --version
GNU bash, version 4.4.12(1)-release (arm-unknown-linux-gnueabihf)
Copyright (C) 2016 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

pi@raspberrypi:~/gimme $ ./gimme -k
./gimme: line 478: /home/pi/.gimme/versions/known-versions.txt.new: No such file or directory
mv: cannot stat '/home/pi/.gimme/versions/known-versions.txt.new': No such file or directory
cat: /home/pi/.gimme/versions/known-versions.txt: No such file or directory

Here is a trace: https://gist.github.com/AlekSi/13afc22c0d62008118f5633c8341f9a4

gimme

@@ -92,6 +103,21 @@ _sha256sum() {
 	fi
 }

+# sort versions, handling 1.10 after 1.9, not before 1.2
+# FreeBSD sort has --version-sort, none of the others do


... and use quotes to avoid undesirable YAML float conversion. See also: - travis-ci/gimme#132 - travis-ci/gimme#130

@AlekSi

Addresses review comments by @AlekSi

Another issue caught by AlekSi: the code updating the known versions didn't handle `~/.gimme/versions/` not already existing.

philpennock · 2018-02-21T18:17:57Z

Identified the issues with Raspbian above: it's not Raspbian. It's that ~/.gimme/versions didn't already exist in a place where the new code assumed that it did.

The sort versions are handled: either sort supports --version-sort, or we fall back to --general-numeric-sort after zero-padding any digit sequences after a dot, to make the general-numeric-sort work.

If there's a sort(1) which doesn't handle --general-numeric-sort then that's an issue to care about. But while it's a long-opt and not POSIX, the modern BSD reimplementations of sort make sure to include that flag for compatibility. It's one of the GNUisms which is now "standard" on any maintained platform. For other platforms, we might want to look for a gsort command? But that's a case of "if it's really an issue, fix it".

version sort in --list output

meatballhat

🎷 🐻

philpennock requested review from AlekSi, meatballhat and tianon February 17, 2018 02:50

philpennock force-pushed the dotx_support branch from e77597a to fd746b1 Compare February 17, 2018 04:32

version sort in --list output

27c3461

1.1 1.10 1.2 is bad. 1.1 1.2 .. 1.9 1.10 is good.

philpennock added the enhancement label Feb 17, 2018

philpennock mentioned this pull request Feb 17, 2018

asking for 1.10 selects 1.1 #132

Closed

philpennock mentioned this pull request Feb 17, 2018

Document versions policy stuff #128

Merged

jmank88 mentioned this pull request Feb 18, 2018

increment CI go versions from 1.8.x/1.9.x/tip to 1.9.x/1.10.x/tip golang/dep#1620

Merged

2 tasks

kamilsk mentioned this pull request Feb 18, 2018

fix latest build on 1.7.4 instead of 1.10.0 kamilsk/retry#114

Closed

wkschwartz added a commit to wkschwartz/pigosat that referenced this pull request Feb 18, 2018

Travis doesn't know 1.10.x until 1.10.1 is out

75736a9

travis-ci/gimme#132 (comment) travis-ci/gimme#130

philpennock mentioned this pull request Feb 19, 2018

1.10.x selects "auto" instead of 1.10 #134

Closed

sbinet mentioned this pull request Feb 19, 2018

travis: add go-1.10.x gonum/plot#424

Merged

krasi-georgiev mentioned this pull request Feb 19, 2018

bump to golang 1.10 prometheus/prometheus#3856

Merged

thaJeztah mentioned this pull request Feb 19, 2018

Bump to Go 1.10 containerd/containerd#2008

Merged

This was referenced Feb 20, 2018

chore(ci): add newer versions of go fossapps/pushy#7

Merged

update .travis.yml fossapps/pushy#8

Closed

AlekSi reviewed Feb 21, 2018

View reviewed changes

gimme

@@ -92,6 +103,21 @@ _sha256sum() {

fi

}

# sort versions, handling 1.10 after 1.9, not before 1.2

# FreeBSD sort has --version-sort, none of the others do

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

AlekSi mentioned this pull request Feb 21, 2018

Use 1.10 for bootstrapping #133

Merged

oplehto mentioned this pull request Feb 21, 2018

Test with Go 1.10 jumptrading/influx-spout#26

Merged

cyberhck mentioned this pull request Feb 21, 2018

version sort in --list output #131

Merged

mjs added a commit to jumptrading/influx-spout that referenced this pull request Feb 21, 2018

Specify exactly Go 1.10 as TravisCI not handling .x syntax

42f18cf

... and use quotes to avoid undesirable YAML float conversion. See also: - travis-ci/gimme#132 - travis-ci/gimme#130

philpennock added 2 commits February 21, 2018 13:07

resolve version via ENV; fix documented flag

7dd7a51

Addresses review comments by @AlekSi

Make the versions dir if doesn't exist

555f15e

Another issue caught by AlekSi: the code updating the known versions didn't handle `~/.gimme/versions/` not already existing.

Merge pull request #131 from travis-ci/resort_dash_l

ef7d682

version sort in --list output

meatballhat approved these changes Feb 21, 2018

View reviewed changes

meatballhat merged commit e61f3e6 into doc_versions_policy Feb 21, 2018

meatballhat deleted the dotx_support branch February 21, 2018 20:59

jmank88 mentioned this pull request Feb 21, 2018

change CI to 1.10.x; update docs golang/dep#1708

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add .x resolution and --resolve command #130

Add .x resolution and --resolve command #130

philpennock commented Feb 17, 2018

philpennock commented Feb 17, 2018

philpennock commented Feb 17, 2018 •

edited

Loading

philpennock commented Feb 17, 2018

AlekSi left a comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

AlekSi commented Feb 21, 2018 •

edited

Loading

This comment was marked as spam.

This comment was marked as spam.

philpennock commented Feb 21, 2018

meatballhat left a comment

Add .x resolution and --resolve command #130

Add .x resolution and --resolve command #130

Conversation

philpennock commented Feb 17, 2018

philpennock commented Feb 17, 2018

philpennock commented Feb 17, 2018 • edited Loading

philpennock commented Feb 17, 2018

AlekSi left a comment

Choose a reason for hiding this comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

AlekSi commented Feb 21, 2018 • edited Loading

This comment was marked as spam.

This comment was marked as spam.

philpennock commented Feb 21, 2018

meatballhat left a comment

Choose a reason for hiding this comment

philpennock commented Feb 17, 2018 •

edited

Loading

AlekSi commented Feb 21, 2018 •

edited

Loading