-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Ember dependencies to 3.7.* #1920
Conversation
This fixes this deprecation: ember-polyfills.deprecate-merge
I was wrong that the merge deprecations were all gone, this was producing one too. I don’t know why Greenkeeper isn’t suggesting updates…? ember-intercom-io is also using merge, but I had to revert its update yesterday. I’ll look into that. When I replaced merge with assign directly in node_modules, there were no more warnings about this deprecation. 🎉
It’s murky as usual but it appears that the |
@backspace In general, I agree with moving away from route actions. Although, I see some cases that would be tricky to handle without them. E.g. global actions that may be triggered in many places across the app, like |
I can find these
So maybe it’s not too much to move away from the helper. |
I deployed to |
Since Sinon was only being used in one place, I rewrote things to fix this deprecation: https://deprecations-app-prod.herokuapp.com/deprecations/v3.x/#toc_getting-the-each-property
I’ve tried this before and was unable to deploy, now is the moment when I’ll see if I can fix that. Because this rids us of this deprecation: https://deprecations-app-prod.herokuapp.com/deprecations/v3.x/#toc_ember-polyfills-deprecate-merge
I don’t know what changed in package-lock.json but now I think deployments might succeed…? 🧐
what is happening
# Conflicts: # package-lock.json # package.json
# Conflicts: # package-lock.json # package.json # tests/unit/services/live-updates-record-fetcher-test.js
There was a warning that the older version wasn’t compatible with this version of ember-cli-babel.
We already have babel.includePolyfill so I think this is superfluous.
This is another Ember 3.6-related update.
This appears to silence the volumes of Babel deprecation warnings such as the one seen here: https://travis-ci.org/travis-ci/travis-web/builds/477551778#L512
This is another dependency with a newer ember-cli-babel version.
# Conflicts: # package-lock.json
This fixes a Babel 7 interoperation problem.
This seems like a strange change…?
The devDependency ember-source was updated from
3.5.1
to3.6.0
.This version is not covered by your current version range.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
Find out more about this release.
FAQ and help
There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper bot 🌴