Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ember dependencies to 3.7.* #1920

Merged
merged 43 commits into from
Jan 28, 2019
Merged

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Dec 7, 2018

The devDependency ember-source was updated from 3.5.1 to 3.6.0.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Find out more about this release.

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

This fixes this deprecation: ember-polyfills.deprecate-merge
I was wrong that the merge deprecations were all gone,
this was producing one too. I don’t know why Greenkeeper
isn’t suggesting updates…?

ember-intercom-io is also using merge, but I had to revert
its update yesterday. I’ll look into that. When I replaced
merge with assign directly in node_modules, there were
no more warnings about this deprecation. 🎉
@backspace
Copy link
Contributor

It’s murky as usual but it appears that the remove-handler-infos deprecation is being triggered by the use of the ember-route-action-helper addon. Given the RFC discussion on route actions seems to be leaning toward not adding route actions and even maybe route actions are actively discouraged, so it’s perhaps wise to move away from using this addon altogether. I’m not sure how involved that would be.

@artursmirnov
Copy link
Contributor

@backspace In general, I agree with moving away from route actions. Although, I see some cases that would be tricky to handle without them. E.g. global actions that may be triggered in many places across the app, like signIn, signOut, triggerSomeModal, etc. I didn't read the entire thread about route actions, so may be they suggest something for such cases 🤔

@backspace
Copy link
Contributor

I can find these route-action helpers in use:

  • helpscoutTrigger, soon to be removed
  • showRepositories and viewSearchResults
    • these change the active tab in the sidebar via transitionTo, I think they could be moved into a sidebar service…?
  • signIn and signOut
    • I think these could live on the auth service

So maybe it’s not too much to move away from the helper.

@backspace
Copy link
Contributor

I deployed to org-staging and checked Google Analytics and can confirm that it’s still sending events after 7b90f24.

Since Sinon was only being used in one place, I rewrote things
to fix this deprecation:
https://deprecations-app-prod.herokuapp.com/deprecations/v3.x/#toc_getting-the-each-property
I’ve tried this before and was unable to deploy, now is the
moment when I’ll see if I can fix that. Because this rids
us of this deprecation:
https://deprecations-app-prod.herokuapp.com/deprecations/v3.x/#toc_ember-polyfills-deprecate-merge
I don’t know what changed in package-lock.json but now
I think deployments might succeed…? 🧐
what is happening
# Conflicts:
#	package-lock.json
#	package.json
# Conflicts:
#	package-lock.json
#	package.json
#	tests/unit/services/live-updates-record-fetcher-test.js
There was a warning that the older version wasn’t compatible
with this version of ember-cli-babel.
We already have babel.includePolyfill so I think this
is superfluous.
This is another dependency with a newer ember-cli-babel
version.
@backspace backspace changed the title Update ember-source to the latest version 🚀 Update Ember dependencies to 3.7.* Jan 15, 2019
This fixes a Babel 7 interoperation problem.
This seems like a strange change…?
@backspace backspace merged commit e6c5055 into master Jan 28, 2019
@backspace backspace deleted the greenkeeper/ember-source-3.6.0 branch January 28, 2019 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants