Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load catalogs concurrently by default #17094

Closed
wants to merge 1 commit into from
Closed

Load catalogs concurrently by default #17094

wants to merge 1 commit into from

Conversation

findepi
Copy link
Member

@findepi findepi commented Apr 18, 2023

experimental.concurrent-startup was enabled in tests for quite some time. It is believed the functionality can be enabled by default.

@findepi
Load catalogs concurrently by default
2a7657a 
`experimental.concurrent-startup` was enabled in tests for quite some
time. It is believed the functionality can be enabled by default.
@findepi findepi requested review from electrum, Randgalt, losipiuk and a team April 18, 2023 09:57
@cla-bot cla-bot bot added the cla-signed label Apr 18, 2023
@kokosing
Copy link
Member

What problem are you solving? Why do we need to change this? I am concerned that troubleshooting now will be more complex because mixed output.

electrum
electrum requested changes Apr 18, 2023
View reviewed changes
Copy link
Member

@electrum electrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was against this feature from the beginning. I thought it was only added to speed up tests. My vote is to drop it entirely, or only make it available for tests.

What problem is this solving?

@dain
Copy link
Member

dain commented Apr 18, 2023

I agree with @kokosing and @electrum. I wasn't aware this was a concern for end users.

@findepi
Copy link
Member Author

findepi commented Apr 19, 2023

Startup time may matter not only for tests (but for tests primarily), so this is improvement for everyone.
I don't think at this point we should expect any concurrency-related problems, but if there are any, we rather know about them sooner, as we march towards Dynamic Catalogs (#12709).

@findepi findepi closed this Apr 19, 2023
@findepi findepi deleted the findepi/load-catalogs-concurrently-by-default-cd20b5 branch April 19, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@electrum electrum electrum requested changes

@hashhar hashhar hashhar approved these changes

@raunaqmorarka raunaqmorarka raunaqmorarka approved these changes

@Randgalt Randgalt Awaiting requested review from Randgalt

@losipiuk losipiuk Awaiting requested review from losipiuk

Assignees
No one assigned
Labels
cla-signed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@findepi @kokosing @dain @electrum @raunaqmorarka @hashhar