Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load catalogs concurrently by default #17094

Closed
wants to merge 1 commit into from
Closed

Load catalogs concurrently by default #17094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions core/trino-main/src/main/java/io/trino/server/ServerConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

import io.airlift.configuration.Config;
import io.airlift.configuration.ConfigDescription;
import io.airlift.configuration.LegacyConfig;
import io.airlift.units.Duration;

import javax.validation.constraints.NotNull;
Expand All @@ -26,7 +27,7 @@
public class ServerConfig
{
private boolean coordinator = true;
private boolean concurrentStartup;
private boolean concurrentStartup = true;
private boolean includeExceptionInResponse = true;
private Duration gracePeriod = new Duration(2, MINUTES);
private boolean queryResultsCompressionEnabled = true;
Expand All @@ -49,7 +50,8 @@ public boolean isConcurrentStartup()
return concurrentStartup;
}

@Config("experimental.concurrent-startup")
@LegacyConfig("experimental.concurrent-startup")
@Config("concurrent-startup")
@ConfigDescription("Parallelize work during server startup")
public ServerConfig setConcurrentStartup(boolean concurrentStartup)
{
Expand Down
6 changes: 3 additions & 3 deletions core/trino-main/src/test/java/io/trino/server/TestServerConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public void testDefaults()
{
assertRecordedDefaults(recordDefaults(ServerConfig.class)
.setCoordinator(true)
.setConcurrentStartup(false)
.setConcurrentStartup(true)
.setIncludeExceptionInResponse(true)
.setGracePeriod(new Duration(2, MINUTES))
.setQueryResultsCompressionEnabled(true)
Expand All @@ -43,7 +43,7 @@ public void testExplicitPropertyMappings()
{
Map<String, String> properties = ImmutableMap.<String, String>builder()
.put("coordinator", "false")
.put("experimental.concurrent-startup", "true")
.put("concurrent-startup", "false")
.put("http.include-exception-in-response", "false")
.put("shutdown.grace-period", "5m")
.put("query-results.compression-enabled", "false")
Expand All @@ -52,7 +52,7 @@ public void testExplicitPropertyMappings()

ServerConfig expected = new ServerConfig()
.setCoordinator(false)
.setConcurrentStartup(true)
.setConcurrentStartup(false)
.setIncludeExceptionInResponse(false)
.setGracePeriod(new Duration(5, MINUTES))
.setQueryResultsCompressionEnabled(false)
Expand Down
1 change: 0 additions & 1 deletion .../docker/presto-product-tests/common/standard-multinode/multinode-master-config.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ node.id=will-be-overwritten
node.environment=test

coordinator=true
experimental.concurrent-startup=true
node-scheduler.include-coordinator=false
http-server.http.port=8080
query.max-memory=1GB
Expand Down
1 change: 0 additions & 1 deletion .../docker/presto-product-tests/common/standard-multinode/multinode-worker-config.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ node.id=will-be-overwritten
node.environment=test

coordinator=false
experimental.concurrent-startup=true
http-server.http.port=8081
query.max-memory=1GB
query.max-memory-per-node=1GB
Expand Down
1 change: 0 additions & 1 deletion ...launcher/src/main/resources/docker/presto-product-tests/common/standard/config.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ node.id=will-be-overwritten
node.environment=test

coordinator=true
experimental.concurrent-startup=true
node-scheduler.include-coordinator=true
http-server.http.port=8080
query.max-memory=2GB
Expand Down
1 change: 0 additions & 1 deletion testing/trino-server-dev/etc/config.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
node.id=ffffffff-ffff-ffff-ffff-ffffffffffff
node.environment=test
node.internal-address=localhost
experimental.concurrent-startup=true
http-server.http.port=8080

discovery.uri=http://localhost:8080
Expand Down