Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native S3 filesystem for Databricks tests #21135

Closed
wants to merge 1 commit into from

Conversation

findepi
Copy link
Member

@findepi findepi commented Mar 18, 2024

No description provided.

@findepi
Copy link
Member Author

findepi commented Mar 18, 2024

https://github.com/trinodb/trino/actions/runs/8328234946/job/22788586388?pr=21135

tests               | 2024-03-18 21:02:28 INFO: FAILURE     /    io.trino.tests.product.deltalake.TestDeltaLakeDropTableCompatibility.testDropTable [DELTA, TRINO, false] (Groups: profile_specific_tests, delta-lake-databricks, delta-lake-oss) took 6.5 seconds
tests               | 2024-03-18 21:02:28 SEVERE: Failure cause:
tests               | java.lang.AssertionError: 
tests               | Expecting empty but was: [S3ObjectSummary{bucketName='trino-ci-test', key='databricks-compatibility-test-test_schema_with_location_v1sr4lb010/test_managed_table/_delta_log/', eTag='d41d8cd98f00b204e9800998ecf8427e', size=0, lastModified=Mon Mar 18 21:02:24 NPT 2024, storageClass='STANDARD', owner=S3Owner [name=null,id=7d512521745b1fed95f75b82a44da08b9b914f961c1e18d21a91984d34f70333]', restoreStatus=null}]

not sure if related, will re-run

@findepi
Copy link
Member Author

findepi commented Mar 18, 2024

TestDeltaLakeDropTableCompatibility.testDropTable [DELTA, TRINO, false] fails apparently deterministically.

this is not related to canned ACL though.
I think this is a product bug where DROP TABLE isn't fully cleaning up S3 location, and test verified that

cc @findinpath

@findepi
Copy link
Member Author

findepi commented Mar 18, 2024

this is known as #21111

@findepi
Copy link
Member Author

findepi commented Mar 25, 2024

-> #21176

@findepi findepi closed this Mar 25, 2024
@findepi findepi deleted the findepi/s3-native-dbr branch March 25, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants