-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete also blobs ending in slash when deleting directory contents #21145
Delete also blobs ending in slash when deleting directory contents #21145
Conversation
lib/trino-filesystem-s3/src/test/java/io/trino/filesystem/s3/AbstractTestS3FileSystem.java
Outdated
Show resolved
Hide resolved
lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3FileSystem.java
Show resolved
Hide resolved
/test-with-secrets sha=723929b0c851fc76607639506c5b5309a32c5f95 |
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/8334770270 |
2be7961
to
cca6b2d
Compare
@findinpath can you also confirm if #21135 (comment) is green with this fix? |
Yes, I can. The current solution works as expected also for Databricks tests. |
lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3FileSystem.java
Show resolved
Hide resolved
lib/trino-filesystem-s3/src/test/java/io/trino/filesystem/s3/AbstractTestS3FileSystem.java
Outdated
Show resolved
Hide resolved
cca6b2d
to
0b5b6fa
Compare
Unrelated CI failure |
lib/trino-filesystem-s3/src/test/java/io/trino/filesystem/s3/AbstractTestS3FileSystem.java
Outdated
Show resolved
Hide resolved
AWS S3 allows creating "folder" blobs with the media type "application/x-directory". These blobs should be deleted as well along with the normal blobs when deleting the contents of a directory in order to ensure that the directory corresponding to a table is actually fully deleted.
0b5b6fa
to
5fda039
Compare
/test-with-secrets sha=5fda039a57f5e106d3c0990f93da389a1f4c30cd |
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/8357686550 |
Description
AWS S3 allows creating "folder" blobs with the media type "application/x-directory". These blobs should be deleted as well along with the normal blobs when deleting the contents of a directory in order to ensure that the directory corresponding to a table is actually fully deleted.
Additional context and related issues
Use solution inspired from #13974
Fixes #21111
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: