Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move timestamp to the left #23744

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Move timestamp to the left #23744

wants to merge 1 commit into from

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Oct 10, 2024

Description

Before:

Screenshot 2024-10-10 at 22 25 43

After:

Screenshot 2024-10-10 at 22 23 23

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Oct 10, 2024
@wendigo wendigo requested a review from mosabua October 10, 2024 20:26
@github-actions github-actions bot added the ui Web UI label Oct 10, 2024
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result seems fine. I assume you tested it with resizing the window and it behaves ok.

Ideally we would avoid using negative margin values and figure out what is causing the right hand code block to overlap into it or be so close - but given this is our legacy UI I am fine with this fix.

@martint
Copy link
Member

martint commented Oct 10, 2024

This seems to have broken in a recent change. It used to look ok before. Do we know what broke it? Can we address the underlying issue instead?

@mosabua
Copy link
Member

mosabua commented Oct 10, 2024

My gut feeling tells me it has to do with the syntax highlighting we added to the list.

@mosabua
Copy link
Member

mosabua commented Oct 10, 2024

Hm .. weirdly I am not observing the spacing issue in #23748 .. see the screenshots there.

Update .. I see it now as well..

@@ -426,6 +426,7 @@ pre {
.query-header-timestamp {
text-align: right;
color: #b1b1b1;
margin-left: -15px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that .query also has the margin-left .. I wonder what happens if we remove that there instead..

@mosabua
Copy link
Member

mosabua commented Oct 11, 2024

Turns out those negative margins (paired with identical value positive padding) are everywhere .. all the way up into the .row setup of bootstrap .. so I think we just ship this since its working. Cleaning up that CSS is probably a waste of time.

@wendigo
Copy link
Contributor Author

wendigo commented Oct 11, 2024

@martint my change broke the height and the position of a date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants