Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust height of query display box #23748

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Oct 10, 2024

Description

In the query list to be the same height as the overview/stats display.

Before

Screenshot 2024-10-10 at 4 22 34 PM

After

Screenshot 2024-10-10 at 4 22 46 PM

Additional context and related issues

Fixes #23746

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

The change it too minor .. users probably didnt notice the issue in the first place

@martint
Copy link
Member

martint commented Oct 10, 2024

There’s still a small gap.

@mosabua
Copy link
Member Author

mosabua commented Oct 10, 2024

There’s still a small gap.

I know .. I thought that is visually more pleasing but I can remove that .. I am still looking into why I get no syntax highlighting .. stay tuned.

In the query list to the same height as the overview/stats display
on the left of the query display..
@mosabua
Copy link
Member Author

mosabua commented Oct 11, 2024

Updated screenshot with fix - now height is same as left hand .. 160 px .. more forces the left hand to go taller as well .. so thats no good either.

image

@wendigo wendigo merged commit 9c25f0c into trinodb:master Oct 11, 2024
93 checks passed
@github-actions github-actions bot added this to the 462 milestone Oct 11, 2024
@mosabua mosabua deleted the render branch October 11, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Gap below query text in UI
3 participants