Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tooltips for settings buttons. Fixed naming inconsistency. #12918

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kevinjin12
Copy link

Notes to Reviewer

My first ever pull request!

Fixes Issue #12777 adding tooltips to clarify meaning. Also renamed engine preferences tab to maintain consistency with button name.

{3E06D535-3813-4629-8249-7DAB32E61528}

@CLAassistant
Copy link

CLAassistant commented Oct 3, 2024

CLA assistant check
All committers have signed the CLA.

@Cernelius
Copy link
Contributor

Maybe "Settings" would be better than "Engine Preferences" for both?

@frigoref
Copy link
Member

frigoref commented Oct 7, 2024

I would leave the code as it is. The tooltips are just reiterating the text and are not necessary from my perspective. The popping up of a tooltip is not user friendly when there is not much added value.
Renaming "Settings" to something more specific would be good I think. How about "Engine Settings"?

@Cernelius
Copy link
Contributor

How about "Engine Settings"?

"Program Settings" would feel better to me, but I'm not sure what is the difference between "program" and "engine" and which one is the better term.

I'll point out that the Windows folder where TripleA is installed is called "Programs", not "Engines".

@Cernelius
Copy link
Contributor

Also, maybe it should be "Program's Settings" or "Engine's Settings", shouldn't it?

@Cernelius
Copy link
Contributor

Or maybe "General Settings" would be better from a user's perspective (mainly to differentiate them from more specific settings like the zoom (which is a "Map Setting", that is applying to every game of the same map) or the "Game Options", which are the settings for the game).

In practice, TripleA has 3 levels of settings:
1- Those which apply to all games
2- Those which apply to the map only (so to every game of the map)
3- Those which apply to the game only

It would be good to make them consistent and clear, but at this point I would say that this matter deserves its own issue or even forum thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants