Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tooltips for settings buttons. Fixed naming inconsistency. #12918

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added tooltips for settings buttons. Fixed naming inconsistency. #12918

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions game-app/game-core/src/main/java/games/strategy/triplea/settings/SettingsWindow.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public void close() {
public void open(final Frame owner) {
Preconditions.checkState(SwingUtilities.isEventDispatchThread());
if (dialog == null) {
dialog = new JDialog(owner, "Settings");
dialog = new JDialog(owner, "Engine Preferences");
dialog.setContentPane(newContentPane());
dialog.setMinimumSize(new Dimension(400, 50));
dialog.pack();
Expand Down Expand Up @@ -199,19 +199,29 @@ private JComponent buildButtonPanel() {
.horizontalAlignmentCenter()
.boxLayoutHorizontal()
.addHorizontalGlue()
.add(new JButtonBuilder().title("Save").actionListener(this::saveSettings).build())
.add(new JButtonBuilder()
.title("Save")
.toolTipText("Save changes")
.actionListener(this::saveSettings)
.build())
.addHorizontalStrut(5)
.add(new JButtonBuilder().title("Close").actionListener(this::close).build())
.add(new JButtonBuilder()
.title("Close")
.toolTipText("Close settings menu")
.actionListener(this::close)
.build())
.addHorizontalStrut(5)
.add(
new JButtonBuilder()
.title("Reset to Saved")
.toolTipText("Reset settings to their last saved state")
.actionListener(this::resetSettings)
.build())
.addHorizontalStrut(5)
.add(
new JButtonBuilder()
.title("Reset to Default")
.toolTipText("Reset settings to default settings")
.actionListener(this::resetSettingsToDefault)
.build())
.addHorizontalGlue()
Expand Down