Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artificial Density Diffusion should only be applied to the same system #608

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

svchb
Copy link
Collaborator

@svchb svchb commented Aug 21, 2024

No description provided.

@svchb svchb added the bug Something isn't working label Aug 21, 2024
@svchb svchb requested a review from efaulhaber August 21, 2024 22:10
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.90%. Comparing base (05a11e9) to head (fa5f166).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...fluid/weakly_compressible_sph/density_diffusion.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #608   +/-   ##
=======================================
  Coverage   69.89%   69.90%           
=======================================
  Files          86       86           
  Lines        5122     5123    +1     
=======================================
+ Hits         3580     3581    +1     
  Misses       1542     1542           
Flag Coverage Δ
unit 69.90% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svchb svchb enabled auto-merge (squash) September 19, 2024 10:43
@svchb svchb merged commit 33f6f86 into trixi-framework:main Sep 20, 2024
10 checks passed
@svchb svchb mentioned this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants