Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Open Boundary Systems for free surfaces #609

Open
wants to merge 45 commits into
base: main
Choose a base branch
from

Conversation

svchb
Copy link
Collaborator

@svchb svchb commented Aug 22, 2024

Depends on #610
Depends on #608
Depends on #606
Depends on #605
Depends on #603
Depends on #599

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 69.34%. Comparing base (eb9f41b) to head (cde7990).

Files with missing lines Patch % Lines
...oundary/open_boundary/method_of_characteristics.jl 44.44% 5 Missing ⚠️
src/schemes/boundary/open_boundary/system.jl 69.23% 4 Missing ⚠️
...c/schemes/boundary/open_boundary/boundary_zones.jl 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #609      +/-   ##
==========================================
- Coverage   69.37%   69.34%   -0.04%     
==========================================
  Files          85       85              
  Lines        5124     5141      +17     
==========================================
+ Hits         3555     3565      +10     
- Misses       1569     1576       +7     
Flag Coverage Δ
unit 69.34% <66.66%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svchb svchb added bug Something isn't working enhancement New feature or request labels Aug 22, 2024
@svchb svchb marked this pull request as draft August 22, 2024 12:00
@svchb svchb marked this pull request as ready for review October 10, 2024 11:51
@svchb svchb removed the bug Something isn't working label Oct 10, 2024
@svchb svchb mentioned this pull request Oct 10, 2024
@svchb
Copy link
Collaborator Author

svchb commented Oct 10, 2024

Note there were other things in this PR most have been reverted since it is was not leading anywhere. Or it was conflicting with #623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants