use new @trufflesuite/bigint-buffer (#1414)

* use new @trufflesuite/bigint-buffer

* temporarily disable windows tools install

* temporarily revert to previous bigint-buffer lib

* remove msbuild tools

* remove line

* add basic test for bigint-buffer library

* force warning to test

* update warn message for test

* fix tests

* use sinon in test

* trying to force failure in CI

* unforce failed tests

* npm ci to install on PR

* update setup-node action version

* some logging and uninstalling

* correct spelling

* add back msbuild

* removed unnecessary installations

* use trufflesuite's bigint-buffer lib

* update package-lock

* correct bigint-buffer import

* Remove .only from test

Co-authored-by: David Murdoch <[email protected]>

* revert to windows-2019 version for tests

Co-authored-by: David Murdoch <[email protected]>

.github/workflows/pr.yml

@@ -29,38 +29,15 @@ jobs:
           token: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Use Node.js ${{ matrix.node }}
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v2
         with:
           node-version: ${{ matrix.node }}
 
       - name: Add msbuild to PATH
-        # we need msbuild tools for the `bigint-buffer` module
+        # we need msbuild tools for the `bcrypto` module
         if: startsWith(matrix.os, 'windows-')
         uses: microsoft/[email protected]
 
-      - name: install node tools
-        # we don't need to install the windows-build-tools package, as we
-        # already have almost everything we need. We only need to install
-        # python 2.7. Also windows-build-tools@4 fails to install because some
-        # resources it downloads no longer exist, and windows-build-tools@5
-        # fails to install Python (it will wait on the python installer forever)
-        if: startsWith(matrix.os, 'windows-')
-        uses: actions/setup-python@v2
-        with:
-          python-version: "2.7"
-
-      - name: install node-gyp
-        if: startsWith(matrix.os, 'windows-')
-        run: npm install --global [email protected]
-
-      - name: Set node config to use python2.7
-        if: startsWith(matrix.os, 'windows-')
-        run: npm config set python python2.7
-
-      - name: Set node config to set msvs_version to 2019
-        if: startsWith(matrix.os, 'windows-')
-        run: npm config set msvs_version 2019 --global
-
       - run: npm ci
       - run: npm run tsc
       - run: npm test

src/packages/ganache/package.json

@@ -83,7 +83,7 @@
     "webpack-cli": "4.5.0"
   },
   "dependencies": {
-    "bigint-buffer": "1.1.5",
+    "@trufflesuite/bigint-buffer": "1.1.9",
     "bufferutil": "4.0.3",
     "keccak": "3.0.1",
     "leveldown": "5.6.0",

src/packages/ganache/webpack/webpack.node.config.ts

@@ -35,7 +35,7 @@ const config: webpack.Configuration = merge({}, base, {
   },
   externals: [
     //#region dependencies that have the potential to compile something at install time
-    "bigint-buffer",
+    "@trufflesuite/bigint-buffer",
     "leveldown",
     "secp256k1",
     "keccak",

src/packages/utils/package.json

@@ -26,7 +26,8 @@
   },
   "scripts": {
     "tsc": "ttsc --build",
-    "test": "echo 'no tests'"
+    "test": "npm run mocha",
+    "mocha": "cross-env TS_NODE_COMPILER=ttypescript TS_NODE_FILES=true mocha -s 0 -t 0 --exit --check-leaks --throw-deprecation --trace-warnings --require ts-node/register 'tests/**/*.test.ts'"
   },
   "bugs": {
     "url": "https://github.com/trufflesuite/ganache/issues"
@@ -56,11 +57,12 @@
     "@types/seedrandom": "3.0.1",
     "cross-env": "7.0.3",
     "mocha": "8.4.0",
+    "sinon": "11.1.2",
     "ts-node": "9.1.1",
     "ttypescript": "1.5.12",
     "typescript": "4.1.3"
   },
   "optionalDependencies": {
-    "bigint-buffer": "1.1.5"
+    "@trufflesuite/bigint-buffer": "1.1.9"
   }
 }

src/packages/utils/src/common.ts

@@ -1 +1 @@
-export { toBufferBE, toBigIntBE } from "bigint-buffer";
+export { toBufferBE, toBigIntBE } from "@trufflesuite/bigint-buffer";

src/packages/utils/src/utils/buffer-to-bigint.ts

@@ -1,4 +1,4 @@
-import { toBigIntBE } from "bigint-buffer";
+import { toBigIntBE } from "@trufflesuite/bigint-buffer";
 /**
  * note: this doesn't handle negative values
  * @param value Buffer representation of a bigint, most-significant bit first (Big-endian)