This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix: ensure impersonated "large" accounts use compliant (fake) private keys #2602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmurdoch
changed the title
davidmurdoch
changed the title
davidmurdoch
force-pushed
the
develop
branch
3 times, most recently
from
96d6c7f
to
47d583d
Compare
davidmurdoch
force-pushed
the
fix/fake-signing
branch
from
5f78b56
to
5bd1931
Compare
davidmurdoch
changed the title
davidmurdoch
force-pushed
the
fix/fake-signing
branch
from
5bd1931
to
8f1850f
Compare
davidmurdoch
changed the title
davidmurdoch
force-pushed
the
fix/fake-signing
branch
from
8f1850f
to
b29f33b
Compare
davidmurdoch
changed the title
davidmurdoch
commented
Apr 21, 2022
davidmurdoch
commented
Apr 21, 2022
|
closing in favor of #2944 |
This was referenced Nov 23, 2023
This was referenced Mar 12, 2024
This was referenced Mar 20, 2024
This was referenced Mar 27, 2024
This was referenced Apr 16, 2024
This was referenced Apr 17, 2024
This was referenced Oct 11, 2024
This was referenced Oct 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transactions from "impersonated" accounts are still "signed" by Ganache, but the private key is faked. It was previously possible for the fake private key we generate for some accounts to cause an error when a transaction is eventually signed.
Fixes #2586