Update heapless, remove unneeded typenum dependency, and fix formatting as well as clippy warnings. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warning on unit errors is not useful, heapless does the same
Closed
|
@nickray Hey Nicolas, Thanks + Greetings from Bern |
sosthene-nitrokey
requested review from
nickray,
daringer,
robin-nitrokey and
a team
daringer
approved these changes
Jun 19, 2024
robin-nitrokey
approved these changes
Jun 19, 2024
|
Yes, I want to remove the CBOR stuff (unused, and out of place). I also want remove the |
|
I also thought about removing the public heapless dependency. But AFAIS we don’t have a way to support multiple heapless versions because heapless does not have a way to construct a vec from raw parts. |
|
I'll open an issue for that discussion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.