Track mouse events if there's such things. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this patch, one doesn't get mouse events if there's touch functionality available. This is a problematic choice for multiple reasons: - When seeking, the current code triggers a start of a ControlsTimer making controls to fade out. - There's something wrong with the touch screen part of the handling, making it such that touchstart events handler is not executed in Pixel2 (can't say for other devices) even though the handler is registered just fine and touchstart events are flowing somewhere according to the console. This combination of issues leads into situation where when interacting with the controls it ends up fading away and staying away. After this patch, one gets mouse events if system knows how to send them and move triggers showing of the controls. This works as before for every non-touch-enabled devices, and significantly better for pixel2, whether it is used by touching or by mouse. Unclear how a pure touch-only device would behave though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this patch, one doesn't get mouse events if there's touch functionality available.
This is a problematic choice for multiple reasons:
is not executed in Pixel2 (can't say for other devices) even though the handler is registered just fine and touchstart
events are flowing somewhere according to the console.
This combination of issues leads into situation where when interacting with the controls it ends up fading away and staying away.
After this patch, one gets mouse events if system knows how to send them and move triggers showing of the controls.
This works as before for every non-touch-enabled devices, and significantly better for pixel2, whether it is used by touching or by mouse. Unclear how a pure touch-only device would behave though.