Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track mouse events if there's such things. #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Track mouse events if there's such things. #1

wants to merge 1 commit into from

Commits on Nov 27, 2016

  1. Track mouse events if there's such things. 

    Prior to this patch, one doesn't get mouse events if there's touch functionality available.
This is a problematic choice for multiple reasons:

 - When seeking, the current code triggers a start of a ControlsTimer making controls to fade out.
 - There's something wrong with the touch screen part of the handling, making it such that touchstart events handler
   is not executed in Pixel2 (can't say for other devices) even though the handler is registered just fine and touchstart
   events are flowing somewhere according to the console.
This combination of issues leads into situation where when interacting with the controls it ends up fading away and staying away.

After this patch, one gets mouse events if system knows how to send them and move triggers showing of the controls.
This works as before for every non-touch-enabled devices, and significantly better for pixel2, whether it is used by touching or by mouse. Unclear how a pure touch-only device would behave though.
    @ttimonen
    ttimonen committed Nov 27, 2016
    Configuration menu
    Copy the full SHA
    5c6d261 View commit details
    Browse the repository at this point in the history