Lldp lshw upload status #123
Conversation
…onfigurable states
… logic during intake
|
@dallasmarlow @Primer42 |
| @@ -89,9 +89,11 @@ object AssetLifecycle { | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Call me crazy - is this just a cosmetic change? Did you actually change any functionality here?
There was a problem hiding this comment.
No functionality change. Just did it out of OCD. I can revert this change if you would like, as it is not necessary.
There was a problem hiding this comment.
No, I totally understand OCD / having consistent, clearer code. I just wanted to make sure I wasn't missing a subtle diff. Leave it.
|
LGTM |
| Asset.inTransaction { | ||
| options.get("lshw").foreach{lshw => | ||
| parseLshw(asset, new LshwParser(lshw)).left.foreach{throw _} | ||
| InternalTattler.informational(asset, None, "Parsing and storing LSHW data succeeded") |
There was a problem hiding this comment.
nice use of the tattler
|
@dallasmarlow @Primer42 addressed your concerns, and confirmed this is functional. |
| @@ -155,6 +149,31 @@ object AssetLifecycle { | |||
| }.left.map(e => handleException(asset, "Error updating status/state for asset", e)) | |||
| } | |||
|
|
|||
| protected def updateAnyServer(asset: Asset, options: Map[String,String]): Status[Boolean] = { | |||
There was a problem hiding this comment.
@byxorna totally a nitpick, but i think this method name is a bit misleading. you can't actually update "any" server, just server assets that are in a configured allowed status for updates. why not just updateServer?
There was a problem hiding this comment.
Because there is already an updateServer with the same signature :(
https://github.com/tumblr/collins/pull/123/files#diff-0d4ee0e3fc6b2506b41bee0e38c66d21L101
|
@dallasmarlow changed |
|
@byxorna lgtm, lets deploy tomorrow |
add documentation for feature added in #123
Lldp lshw upload status
Lldp lshw upload status
Allows LLDP/LSHW updates to assets in configurable statuses, instead of disallowing updates when in status other than [NEW,INCOMPLETE,MAINTENANCE].
i.e.