[WIP] Inline reply/boost/favourite counters #1369
Conversation
There was a problem hiding this comment.
@connyduck mentioned that he'd like to see a preference to control this - is there a plan for that?
| countReposts.setText(status.getReblogsCount()>0?String.format(Locale.getDefault(),"%d",status.getReblogsCount()):""); | ||
|
|
||
| if (countReplies!=null) | ||
| countReplies.setText(status.getRepliesCount()>0?String.format(Locale.getDefault(),"%d",status.getRepliesCount()):""); |
There was a problem hiding this comment.
The web UI does "0", "1", "1+" for replies - do we want to do the same?
What's the plan for dealing with many-digit counts on these?
There was a problem hiding this comment.
This is how it works in the Roma fork so carried over the functionality, but open to suggestions.
noln
changed the title
|
@Tak it's always-on in this implementation, but could be switchable in the view layer if that's something that @connyduck is firm on. I've WIP'ed the PR pending feedback. |
|
That's pretty cool! |
|
I think we already had such a PR before? |
There was a problem hiding this comment.
- please add an option to configure this behavior. Default off.
- The numbers next to the icons should have the same color as the icons. Looks way better imo.
- when I boost a status, the number disappears and reappears when unboosting. Liking works fine
- In detail view the like/boost count is now shown twice. I think its better to add the reply count to where we already show the like/boost count instead of showing like/boost twice
| public void migrate(@NonNull SupportSQLiteDatabase database) { | ||
| database.execSQL("ALTER TABLE `ConversationEntity` ADD COLUMN `s_repliesCount` INTEGER NOT NULL DEFAULT 0"); | ||
| } | ||
| }; |
There was a problem hiding this comment.
can you please merge these two Migrations into one?
| @@ -612,32 +628,63 @@ private void handleStatusComposedEvent(StatusComposedEvent event) { | |||
|
|
|||
| if (eventStatus.getInReplyToId().equals(thisThreadsStatusId)) { | |||
| insertStatus(eventStatus, statuses.size()); | |||
| addReplyCount(0, 1); | |||
There was a problem hiding this comment.
This looks like a bug? The detailed status is not guaranteed to be the first one in the list
| countReposts.setText(status.getReblogsCount()>0?String.format(Locale.getDefault(),"%d",status.getReblogsCount()):""); | ||
|
|
||
| if (countReplies!=null) | ||
| countReplies.setText(status.getRepliesCount()>0?String.format(Locale.getDefault(),"%d",status.getRepliesCount()):""); |
There was a problem hiding this comment.
We use numberFormat.format elsewhere, i prefer that
I actually like showing the nuber more than "1" "1+" .
# Conflicts: # app/src/main/java/com/keylesspalace/tusky/appstore/CacheUpdater.kt # app/src/main/java/com/keylesspalace/tusky/appstore/Events.kt # app/src/main/java/com/keylesspalace/tusky/fragment/NotificationsFragment.java # app/src/main/java/com/keylesspalace/tusky/fragment/ViewThreadFragment.java # app/src/main/java/com/keylesspalace/tusky/network/TimelineCases.kt
# Conflicts: # app/src/main/java/com/keylesspalace/tusky/fragment/NotificationsFragment.java # app/src/main/java/com/keylesspalace/tusky/fragment/ViewThreadFragment.java
Added `s_repliesCount` column to ConversationEntity table, with corresponding version bump and schema. Required by the reply count part of the `counters` feature.
Adds counters next to reply, boost and favourite icons on posts.