Show toot stat inline #3413
Show toot stat inline #3413
Conversation
|
|
I've added formatting and a setting |
|
Here is an example. The reply counter was mocked to show how it looks on big numbers |
|
Could probably do with a bit more margin to the images. Otherwise it looks fine. |
|
|
|
That looks good. |
|
(Old PR that can be closed then: #1369) |
|
|
||
| private void setFavouritedCount(int favouritedCount) { | ||
| if (favouritedCountLabel != null) { | ||
| favouritedCountLabel.setText(NumberUtilsKt.shortNumber(favouritedCount)); |
There was a problem hiding this comment.
Since it does not affect conversations or detailed statuses, all these changes should be in StatusViewHolder. No more null check necessary then.
|
@zikasak -- I'm writing the changelog for v22, which includes this PR, and (optionally) a link to your Mastodon profile. If you'd like that to be added please can you send it to me. Thanks. |
|
May I suggest to remove the 0 (zero) indicator? Adding the number only when different from zero increases readability. |
The idea here is: Everytime we get hold of a new version of a post, we update everything about that post everywhere. This makes the distincion between different event types unnecessary, as everythng is just a `StatusChangedEvent`. The main benefit is that posts should be up-to-date more often, which is important considering there is now editing and #3413
Resolves #2486