Remove ReplacementSpan, display diffs using CharacterStyle #3431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
February 12, 2023 18:01
Diff each status against the previous version, comparing the different HTML as XML to produce a structured diff. Mark new content with `<ins>`, deleted content with `<del>`. Convert these to styled spans in `ViewEditsAdapter`.
Fixes issue with diffs splitting on accented characters
Don't use HTML spans and try and format them, create real Android spans. Do this with a custom tag handler that can add custom spans that set the text paint appropriately.
Make the background slightlysofter by drawing it as a roundrect. Make the spans easier to understand by padding the start/end of each one with the width of a " " character. This is visual only, the underlying text is not changed.
# Conflicts: # app/src/main/java/com/keylesspalace/tusky/components/viewthread/edits/ViewEditsViewModel.kt
A ReplacementSpan can't cover multiple lines, so if the modified text was more than a line it ran off the end of the screen. https://medium.com/androiddevelopers/drawing-a-rounded-corner-background-on-text-5a610a95af5 suggests a fix which involves a custom textview.
- Show the most recent version in larger text, both to make the most recent version clearer, and for consistency with the thread view (where the version the user clicked in will also have been shown in larger text) - Scroll the most recent version in to view - Show a pinned header with the author's avatar, display name, and username in one place, instead of duplicating this information in each version of the status.
# Conflicts: # app/src/main/java/com/keylesspalace/tusky/components/viewthread/edits/ViewEditsAdapter.kt # app/src/main/java/com/keylesspalace/tusky/components/viewthread/edits/ViewEditsViewModel.kt
nikclayton
commented
Mar 12, 2023
app/src/main/java/com/keylesspalace/tusky/components/viewthread/edits/ViewEditsViewModel.kt
Outdated
Show resolved
Hide resolved
…d/edits/ViewEditsViewModel.kt
|
History is not the same as a conversation thread. |
yes please change |
…dits # Conflicts: # app/src/main/res/values/strings.xml
nikclayton
changed the title
added 2 commits
June 1, 2023 19:11
- Resolve lint errors
…n/Tusky into 3306-diff-status-edits # Conflicts: # app/src/main/java/com/keylesspalace/tusky/components/viewthread/edits/ViewEditsViewModel.kt # app/src/main/res/values/strings.xml
Done. |
connyduck
approved these changes
Jun 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the use of
ReplacementSpan. It turns out this span type is incompatible with spans that occupy more than one line, and the result is that a longer diff can run off the end of the screen. The alternative means that the diff'd text doesn't have additional padding and rounded corners, but it's better than not being visible.Display the most recent version of the status with larger text. Again, consistent with the thread view.
Display the avatar, name, and username of the poster in a pinned header at the top of the screen, instead of duplicating the information on every edit. This reduces the amount of redundant information on the screen.