-
-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ReplacementSpan, display diffs using CharacterStyle #3431
Remove ReplacementSpan, display diffs using CharacterStyle #3431
Commits on Feb 12, 2023
-
Show the difference between edited statuses
Diff each status against the previous version, comparing the different HTML as XML to produce a structured diff. Mark new content with `<ins>`, deleted content with `<del>`. Convert these to styled spans in `ViewEditsAdapter`.
Nik Clayton committedFeb 12, 2023 Configuration menu - View commit details
-
Copy full SHA for fd93f11 - Browse repository at this point
Copy the full SHA fd93f11View commit details
Commits on Mar 1, 2023
-
Merge branch 'develop' into 3306-diff-status-edits
Nik Clayton committedMar 1, 2023 Configuration menu - View commit details
-
Copy full SHA for 8327cc8 - Browse repository at this point
Copy the full SHA 8327cc8View commit details -
Fixes issue with diffs splitting on accented characters
Nik Clayton committedMar 1, 2023 Configuration menu - View commit details
-
Copy full SHA for 1f40e77 - Browse repository at this point
Copy the full SHA 1f40e77View commit details -
Style edited strings with Android spans
Don't use HTML spans and try and format them, create real Android spans. Do this with a custom tag handler that can add custom spans that set the text paint appropriately.
Nik Clayton committedMar 1, 2023 Configuration menu - View commit details
-
Copy full SHA for 1a85ce5 - Browse repository at this point
Copy the full SHA 1a85ce5View commit details -
Nik Clayton committed
Mar 1, 2023 Configuration menu - View commit details
-
Copy full SHA for 472e774 - Browse repository at this point
Copy the full SHA 472e774View commit details
Commits on Mar 2, 2023
-
Move colors in to theme_colors.xml
Nik Clayton committedMar 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 97ae6c2 - Browse repository at this point
Copy the full SHA 97ae6c2View commit details -
Draw a roundrect for the backoround, add start/end padding
Make the background slightlysofter by drawing it as a roundrect. Make the spans easier to understand by padding the start/end of each one with the width of a " " character. This is visual only, the underlying text is not changed.
Nik Clayton committedMar 2, 2023 Configuration menu - View commit details
-
Copy full SHA for eb42cbf - Browse repository at this point
Copy the full SHA eb42cbfView commit details -
Catch exceptions when parsing XML
Nik Clayton committedMar 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 3a9c72d - Browse repository at this point
Copy the full SHA 3a9c72dView commit details -
Move sorting in to Dispatchers.Default coroutine
Nik Clayton committedMar 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 530ed78 - Browse repository at this point
Copy the full SHA 530ed78View commit details -
Merge branch 'develop' into 3306-diff-status-edits
# Conflicts: # app/src/main/java/com/keylesspalace/tusky/components/viewthread/edits/ViewEditsViewModel.kt
Nik Clayton committedMar 2, 2023 Configuration menu - View commit details
-
Copy full SHA for e9e182d - Browse repository at this point
Copy the full SHA e9e182dView commit details -
Nik Clayton committed
Mar 2, 2023 Configuration menu - View commit details
-
Copy full SHA for 0477f0d - Browse repository at this point
Copy the full SHA 0477f0dView commit details
Commits on Mar 10, 2023
-
Nik Clayton committed
Mar 10, 2023 Configuration menu - View commit details
-
Copy full SHA for b541e73 - Browse repository at this point
Copy the full SHA b541e73View commit details -
Re-order edits, newest status at the bottom
Nik Clayton committedMar 10, 2023 Configuration menu - View commit details
-
Copy full SHA for fce4a01 - Browse repository at this point
Copy the full SHA fce4a01View commit details -
A ReplacementSpan can't cover multiple lines, so if the modified text was more than a line it ran off the end of the screen. https://medium.com/androiddevelopers/drawing-a-rounded-corner-background-on-text-5a610a95af5 suggests a fix which involves a custom textview.
Nik Clayton committedMar 10, 2023 Configuration menu - View commit details
-
Copy full SHA for e73c5d3 - Browse repository at this point
Copy the full SHA e73c5d3View commit details -
Adjust display of edited statuses
- Show the most recent version in larger text, both to make the most recent version clearer, and for consistency with the thread view (where the version the user clicked in will also have been shown in larger text) - Scroll the most recent version in to view - Show a pinned header with the author's avatar, display name, and username in one place, instead of duplicating this information in each version of the status.
Nik Clayton committedMar 10, 2023 Configuration menu - View commit details
-
Copy full SHA for 1c0a59d - Browse repository at this point
Copy the full SHA 1c0a59dView commit details
Commits on Mar 11, 2023
-
Merge branch 'develop' into 3306-diff-status-edits
# Conflicts: # app/src/main/java/com/keylesspalace/tusky/components/viewthread/edits/ViewEditsAdapter.kt # app/src/main/java/com/keylesspalace/tusky/components/viewthread/edits/ViewEditsViewModel.kt
Nik Clayton committedMar 11, 2023 Configuration menu - View commit details
-
Copy full SHA for f2acc9c - Browse repository at this point
Copy the full SHA f2acc9cView commit details -
Merge branch 'develop' into 3306-diff-status-edits
Nik Clayton committedMar 11, 2023 Configuration menu - View commit details
-
Copy full SHA for 34631e7 - Browse repository at this point
Copy the full SHA 34631e7View commit details
Commits on Mar 12, 2023
-
Update app/src/main/java/com/keylesspalace/tusky/components/viewthrea…
…d/edits/ViewEditsViewModel.kt
Nik Clayton committedMar 12, 2023 Configuration menu - View commit details
-
Copy full SHA for 838966b - Browse repository at this point
Copy the full SHA 838966bView commit details
Commits on Jun 1, 2023
-
Merge remote-tracking branch 'origin/develop' into 3306-diff-status-e…
…dits # Conflicts: # app/src/main/res/values/strings.xml
Nik Clayton committedJun 1, 2023 Configuration menu - View commit details
-
Copy full SHA for a135786 - Browse repository at this point
Copy the full SHA a135786View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a2fd68 - Browse repository at this point
Copy the full SHA 2a2fd68View commit details -
Merge branch '3306-diff-status-edits' of https://github.com/nikclayto…
…n/Tusky into 3306-diff-status-edits # Conflicts: # app/src/main/java/com/keylesspalace/tusky/components/viewthread/edits/ViewEditsViewModel.kt # app/src/main/res/values/strings.xml
Nik Clayton committedJun 1, 2023 Configuration menu - View commit details
-
Copy full SHA for 1fdeef8 - Browse repository at this point
Copy the full SHA 1fdeef8View commit details
Commits on Jun 11, 2023
-
Merge branch 'develop' into 3306-diff-status-edits
Nik Clayton committedJun 11, 2023 Configuration menu - View commit details
-
Copy full SHA for 90923dc - Browse repository at this point
Copy the full SHA 90923dcView commit details