Skip to content

Commit

Permalink
Removal of one of the most iconic components of Bootstrap: the jumbot…
Browse files Browse the repository at this point in the history
…ron (#28876)
  • Loading branch information
MartijnCuppens authored and XhmikosR committed Jun 7, 2019
1 parent cafbbdc commit 2ac2a5a
Show file tree
Hide file tree
Showing 26 changed files with 23 additions and 193 deletions.
17 changes: 0 additions & 17 deletions scss/_jumbotron.scss

This file was deleted.

7 changes: 0 additions & 7 deletions scss/_variables.scss
Original file line number Diff line number Diff line change
Expand Up @@ -811,13 +811,6 @@ $pagination-disabled-bg: $white !default;
$pagination-disabled-border-color: $gray-300 !default;


// Jumbotron

$jumbotron-padding: 2rem !default;
$jumbotron-color: null !default;
$jumbotron-bg: $gray-200 !default;


// Cards

$card-spacer-y: .75rem !default;
Expand Down
1 change: 0 additions & 1 deletion scss/bootstrap.scss
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
@import "breadcrumb";
@import "pagination";
@import "badge";
@import "jumbotron";
@import "alert";
@import "progress";
@import "list-group";
Expand Down
29 changes: 0 additions & 29 deletions site/content/docs/4.3/components/jumbotron.md

This file was deleted.

33 changes: 0 additions & 33 deletions site/content/docs/4.3/examples/album/album.css

This file was deleted.

28 changes: 14 additions & 14 deletions site/content/docs/4.3/examples/album/index.html
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
---
layout: examples
title: Album example
extra_css:
- "album.css"
---

<header>
Expand Down Expand Up @@ -39,14 +37,16 @@ <h4 class="text-white">Contact</h4>

<main role="main">

<section class="jumbotron text-center">
<div class="container">
<h1>Album example</h1>
<p class="lead text-muted">Something short and leading about the collection below—its contents, the creator, etc. Make it short and sweet, but not too short so folks don’t simply skip over it entirely.</p>
<p>
<a href="#" class="btn btn-primary my-2">Main call to action</a>
<a href="#" class="btn btn-secondary my-2">Secondary action</a>
</p>
<section class="py-5 text-center container">
<div class="row py-lg-5">
<div class="col-lg-6 col-md-8 mx-auto">
<h1 class="font-weight-light">Album example</h1>
<p class="lead text-muted">Something short and leading about the collection below—its contents, the creator, etc. Make it short and sweet, but not too short so folks don’t simply skip over it entirely.</p>
<p>
<a href="#" class="btn btn-primary my-2">Main call to action</a>
<a href="#" class="btn btn-secondary my-2">Secondary action</a>
</p>
</div>
</div>
</section>

Expand Down Expand Up @@ -197,12 +197,12 @@ <h1>Album example</h1>

</main>

<footer class="text-muted">
<footer class="text-muted py-5">
<div class="container">
<p class="float-right">
<p class="float-right mb-1">
<a href="#">Back to top</a>
</p>
<p>Album example is &copy; Bootstrap, but please download and customize it for yourself!</p>
<p>New to Bootstrap? <a href="/">Visit the homepage</a> or read our <a href="{{< docsref "/getting-started/introduction" >}}">getting started guide</a>.</p>
<p class="mb-1">Album example is &copy; Bootstrap, but please download and customize it for yourself!</p>
<p class="mb-0">New to Bootstrap? <a href="/">Visit the homepage</a> or read our <a href="{{< docsref "/getting-started/introduction" >}}">getting started guide</a>.</p>
</div>
</footer>
2 changes: 1 addition & 1 deletion site/content/docs/4.3/examples/blog/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
</nav>
</div>

<div class="jumbotron p-4 p-md-5 text-white rounded bg-dark">
<div class="p-4 p-md-5 mb-4 text-white rounded bg-dark">
<div class="col-md-6 px-0">
<h1 class="display-4 font-italic">Title of a longer featured blog post</h1>
<p class="lead my-3">Multiple lines of text that form the lede, informing new readers quickly and efficiently about what’s most interesting in this post’s contents.</p>
Expand Down
80 changes: 0 additions & 80 deletions site/content/docs/4.3/examples/jumbotron/index.html

This file was deleted.

4 changes: 0 additions & 4 deletions site/content/docs/4.3/examples/jumbotron/jumbotron.css

This file was deleted.

2 changes: 1 addition & 1 deletion site/content/docs/4.3/examples/navbar-bottom/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
---

<div class="container">
<div class="jumbotron mt-3">
<div class="bg-light p-5 rounded mt-3">
<h1>Bottom Navbar example</h1>
<p class="lead">This example is a quick exercise to illustrate how the bottom navbar works.</p>
<a class="btn btn-lg btn-primary" href="{{< docsref "/components/navbar" >}}" role="button">View navbar docs &raquo;</a>
Expand Down
2 changes: 1 addition & 1 deletion site/content/docs/4.3/examples/navbar-fixed/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
</nav>

<main role="main" class="container">
<div class="jumbotron">
<div class="bg-light p-5 rounded">
<h1>Navbar example</h1>
<p class="lead">This example is a quick exercise to illustrate how fixed to top navbar works. As you scroll, it will remain fixed to the top of your browser’s viewport.</p>
<a class="btn btn-lg btn-primary" href="{{< docsref "/components/navbar" >}}" role="button">View navbar docs &raquo;</a>
Expand Down
2 changes: 1 addition & 1 deletion site/content/docs/4.3/examples/navbar-static/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
</nav>

<main role="main" class="container">
<div class="jumbotron">
<div class="bg-light p-5 rounded">
<h1>Navbar example</h1>
<p class="lead">This example is a quick exercise to illustrate how the top-aligned navbar works. As you scroll, this navbar remains in its original position and moves with the rest of the page.</p>
<a class="btn btn-lg btn-primary" href="{{< docsref "/components/navbar" >}}" role="button">View navbar docs &raquo;</a>
Expand Down
2 changes: 1 addition & 1 deletion site/content/docs/4.3/examples/navbars/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@
</nav>

<main role="main">
<div class="jumbotron">
<div class="bg-light p-5 rounded">
<div class="col-sm-8 mx-auto">
<h1>Navbar examples</h1>
<p>This example is a quick exercise to illustrate how the navbar and its contents work. Some navbars extend the width of the viewport, others are confined within a <code>.container</code>. For positioning of navbars, checkout the <a href="{{< docsref "/examples/navbar-static" >}}">top</a> and <a href="{{< docsref "/examples/navbar-fixed" >}}">fixed top</a> examples.</p>
Expand Down
4 changes: 4 additions & 0 deletions site/content/docs/4.3/migration.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,10 @@ Badges were overhauled to better differentiate themselves from buttons and to be
- **Todo:** Removed `.badge-pill` for the `.rounded-pill` utility class
- **Todo:** Removed badge's hover and focus styles for `a.badge` and `button.badge`.

### Jumbotron

- The jumbotron component is removed in favor of utility classes like `.bg-light` for the background color and `.p-*` classes to control padding.

### Popovers

- Renamed `.arrow` to `.popover-arrow`
Expand Down
2 changes: 0 additions & 2 deletions site/data/examples.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@
description: "Nothing but the basics: compiled CSS and JavaScript."
- name: Grid
description: "Multiple examples of grid layouts with all four tiers, nesting, and more."
- name: Jumbotron
description: "Build around the jumbotron with a navbar and some basic grid columns."

- category: Navbars
description: "Taking the default navbar component and showing how it can be moved, placed, and extended."
Expand Down
1 change: 0 additions & 1 deletion site/data/nav.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@
- title: Dropdowns
- title: Forms
- title: Input group
- title: Jumbotron
- title: List group
- title: Modal
- title: Navs
Expand Down
Binary file modified site/static/docs/4.3/assets/img/examples/album.png
100644 → 100755
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified site/static/docs/4.3/assets/img/examples/[email protected]
100644 → 100755
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified site/static/docs/4.3/assets/img/examples/navbar-bottom.png
100644 → 100755
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified site/static/docs/4.3/assets/img/examples/[email protected]
100644 → 100755
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified site/static/docs/4.3/assets/img/examples/navbar-fixed.png
100644 → 100755
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified site/static/docs/4.3/assets/img/examples/[email protected]
100644 → 100755
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified site/static/docs/4.3/assets/img/examples/navbar-static.png
100644 → 100755
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified site/static/docs/4.3/assets/img/examples/[email protected]
100644 → 100755
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified site/static/docs/4.3/assets/img/examples/navbars.png
100644 → 100755
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified site/static/docs/4.3/assets/img/examples/[email protected]
100644 → 100755
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

2 comments on commit 2ac2a5a

@adrianjguerrero
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why

@JacobThaDev
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOOOOOOOOOOOOOOO
Press F boysssss...rip jumbotron 2k19

Please sign in to comment.