Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of one of the most iconic components of Bootstrap: the jumbotron #28876

Merged
merged 2 commits into from
Jun 7, 2019

Conversation

MartijnCuppens
Copy link
Member

Ditch the jumbotron in favour of utility classes.

@XhmikosR

This comment has been minimized.

@XhmikosR
Copy link
Member

XhmikosR commented Jun 6, 2019

On a side note, bg-light is quite lighter than what we used.

@MartijnCuppens
Copy link
Member Author

On a side note, bg-light is quite lighter than what we used.

I've updated the screenshots because of this. We 'll probably have more grey tints when #28268 is finished (I've added it as a to do).

@XhmikosR, did you optimize the images with your latest push?

@XhmikosR
Copy link
Member

XhmikosR commented Jun 7, 2019

Yeah, everything is good to go from my side.

@XhmikosR XhmikosR merged commit 2ac2a5a into master Jun 7, 2019
@XhmikosR XhmikosR deleted the master-mc-ditch-jumbotron branch June 7, 2019 11:44
@mbejda
Copy link

mbejda commented Sep 13, 2019

Removing the most iconic component. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants