Add align self to navbar brand #21626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jan 9, 2017
| @@ -28,6 +28,7 @@ | |||
| // Used for brand, project, or site names. | |||
|
|
|||
| .navbar-brand { | |||
| align-self: flex-start; | |||
There was a problem hiding this comment.
Properties should be ordered display, align-self, padding-top, padding-bottom, margin-right, font-size, line-height, white-space
|
THIS. |
|
I imagine we'll have issues when folks collapse a navbar without a |
Closed
pvdlg
added a commit
to pvdlg/bootstrap
that referenced
this pull request
Jan 27, 2017
* commit 'cfb25f6995160d1ba03da23c3a01446844f45fec': Add aria-label to docs search field Remove random cursor: default from pill nav (twbs#21835) Allow button toolbars to wrap (twbs#21826) fixes twbs#21567 grunt (fixes twbs#21819) Add align self to navbar brand (twbs#21626) Rename order utilities to intended class names (twbs#21739) Pixel perfect navbar toggler (twbs#21821) Update _custom.scss imports in other builds (twbs#21825) Allow flex-based navs to wrap like they used to (twbs#21824) Remove `cursor: pointer;` (twbs#21812)
rudionrails
added a commit
to joblocal/bootstrap
that referenced
this pull request
Jan 30, 2017
* bootstrap/v4-dev: (979 commits) Add aria-label to docs search field Remove random cursor: default from pill nav (twbs#21835) Allow button toolbars to wrap (twbs#21826) fixes twbs#21567 grunt (fixes twbs#21819) Add align self to navbar brand (twbs#21626) Rename order utilities to intended class names (twbs#21739) Pixel perfect navbar toggler (twbs#21821) Update _custom.scss imports in other builds (twbs#21825) Allow flex-based navs to wrap like they used to (twbs#21824) Remove `cursor: pointer;` (twbs#21812) Fix body padding in Dashboard and Jumbotron examples. Move htmllint to npm script. Change to markdown (twbs#21815) Change header to use markdown (twbs#21809) Update grid layout docs (twbs#21806) grunt Drop Normalize, port relevant parts to Reboot (twbs#21741) grunt Fix container within navbar on smallest breakpoint (twbs#21722) ...
rudionrails
added a commit
to joblocal/bootstrap
that referenced
this pull request
Jan 30, 2017
* bootstrap/v4-dev: (979 commits) Add aria-label to docs search field Remove random cursor: default from pill nav (twbs#21835) Allow button toolbars to wrap (twbs#21826) fixes twbs#21567 grunt (fixes twbs#21819) Add align self to navbar brand (twbs#21626) Rename order utilities to intended class names (twbs#21739) Pixel perfect navbar toggler (twbs#21821) Update _custom.scss imports in other builds (twbs#21825) Allow flex-based navs to wrap like they used to (twbs#21824) Remove `cursor: pointer;` (twbs#21812) Fix body padding in Dashboard and Jumbotron examples. Move htmllint to npm script. Change to markdown (twbs#21815) Change header to use markdown (twbs#21809) Update grid layout docs (twbs#21806) grunt Drop Normalize, port relevant parts to Reboot (twbs#21741) grunt Fix container within navbar on smallest breakpoint (twbs#21722) ...
|
#22230 fixes this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes navbar brand width. Problem is that after navbar collapsed, link become full width:
So, after adding
align-self: flex-start;to.navbar-brandit will have its normal width:Fixes #21621.