Drop Normalize, port relevant parts to Reboot #21741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…we dropped IE9 support
…tyles anyway in _type.scss already
- Move over background-color and text-decoration - Drop focus outline change given it affects the offset on hover of focused links
- Move over template - Move over summary
houndci-bot
reviewed
Jan 16, 2017
| abbr[data-original-title] { | ||
| cursor: help; | ||
| abbr[data-original-title] { // 4 | ||
| border-bottom: none; // 1 |
There was a problem hiding this comment.
border-bottom: 0 is preferred over border-bottom: none
Properties should be ordered text-decoration, cursor, border-bottom
houndci-bot
reviewed
Jan 16, 2017
| box-sizing: border-box; // 1 | ||
| font-family: sans-serif; // 2 | ||
| line-height: 1.15; // 3 | ||
| -ms-text-size-adjust: 100%; // 4 |
houndci-bot
reviewed
Jan 16, 2017
| font-family: sans-serif; // 2 | ||
| line-height: 1.15; // 3 | ||
| -ms-text-size-adjust: 100%; // 4 | ||
| -webkit-text-size-adjust: 100%; // 4 |
houndci-bot
reviewed
Jan 16, 2017
| box-sizing: border-box; // 1 | ||
| font-family: sans-serif; // 2 | ||
| line-height: 1.15; // 3 | ||
| -ms-text-size-adjust: 100%; // 4 |
houndci-bot
reviewed
Jan 21, 2017
| @@ -6,7 +6,8 @@ | |||
| width: 100%; | |||
| max-width: 100%; | |||
| margin-bottom: $spacer; | |||
|
|
|||
| background-color: $table-bg; // Reset for nesting within parents with `background-color`. | |||
|
|
|||
houndci-bot
reviewed
Jan 21, 2017
| @@ -6,7 +6,8 @@ | |||
| width: 100%; | |||
| max-width: 100%; | |||
| margin-bottom: $spacer; | |||
|
|
|||
| background-color: $table-bg; // Reset for nesting within parents with `background-color`. | |||
|
|
|||
|
Just noticed Hound is running twice... 🤔 |
Closed
rudionrails
added a commit
to joblocal/bootstrap
that referenced
this pull request
Jan 30, 2017
* bootstrap/v4-dev: (979 commits) Add aria-label to docs search field Remove random cursor: default from pill nav (twbs#21835) Allow button toolbars to wrap (twbs#21826) fixes twbs#21567 grunt (fixes twbs#21819) Add align self to navbar brand (twbs#21626) Rename order utilities to intended class names (twbs#21739) Pixel perfect navbar toggler (twbs#21821) Update _custom.scss imports in other builds (twbs#21825) Allow flex-based navs to wrap like they used to (twbs#21824) Remove `cursor: pointer;` (twbs#21812) Fix body padding in Dashboard and Jumbotron examples. Move htmllint to npm script. Change to markdown (twbs#21815) Change header to use markdown (twbs#21809) Update grid layout docs (twbs#21806) grunt Drop Normalize, port relevant parts to Reboot (twbs#21741) grunt Fix container within navbar on smallest breakpoint (twbs#21722) ...
rudionrails
added a commit
to joblocal/bootstrap
that referenced
this pull request
Jan 30, 2017
* bootstrap/v4-dev: (979 commits) Add aria-label to docs search field Remove random cursor: default from pill nav (twbs#21835) Allow button toolbars to wrap (twbs#21826) fixes twbs#21567 grunt (fixes twbs#21819) Add align self to navbar brand (twbs#21626) Rename order utilities to intended class names (twbs#21739) Pixel perfect navbar toggler (twbs#21821) Update _custom.scss imports in other builds (twbs#21825) Allow flex-based navs to wrap like they used to (twbs#21824) Remove `cursor: pointer;` (twbs#21812) Fix body padding in Dashboard and Jumbotron examples. Move htmllint to npm script. Change to markdown (twbs#21815) Change header to use markdown (twbs#21809) Update grid layout docs (twbs#21806) grunt Drop Normalize, port relevant parts to Reboot (twbs#21741) grunt Fix container within navbar on smallest breakpoint (twbs#21722) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21740.
This removes a dedicated Normalize.css from the project, merging the relevant parts into Reboot. With the upcoming removal of "opinionated" styles that we rely on, combined with the growing overrides and inconsistencies between Normalize and Reboot, this should simplify things a bit.
This is missing a good amount of attribution (most obviously from Normalize), organization of rulesets, and lacking any real testing yet.
Looking at other open issues and PRs, this also addresses a few bugs.
Closes #21657, fixes #21588, fixes #21652.