Update _screen-reader.scss #22154
Merged
Update _screen-reader.scss #22154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small improvements that could be important: * `clip` [is deprecated](https://www.w3.org/TR/css-masking-1/#clip-property). Adding `clip-path` as progressive enhancement; the shorter notation came from @ryuran 's [suggestion](https://twitter.com/ryuran78/status/778943389819604992); * [J. Renée Beach warned about single pixel with interfering with screen readers vocalisation](https://medium.com/@jessebeach/beware-smushed-off-screen-accessible-text-5952a4c2cbfe#.vcd5xlpgg) solved with `white-space`. See [the detailed post on Hugo Giraudel's blog](http://hugogiraudel.com/2016/10/13/css-hide-and-seek/). Also kinda related to issue #20732 :) Please let me know if you find any trouble with this technique. Thanks a lot!
houndci-bot
reviewed
Mar 10, 2017
scss/mixins/_screen-reader.scss
Outdated
| @@ -27,6 +30,8 @@ | |||
| height: auto; | |||
| margin: 0; | |||
| overflow: visible; | |||
| white-space: normal; | |||
There was a problem hiding this comment.
Properties should be ordered position, width, height, margin, overflow, clip, white-space, clip-path
To pass Hound. Didn't think `clip` and `clip-path` would be considered as unrelated…
houndci-bot
reviewed
Mar 10, 2017
scss/mixins/_screen-reader.scss
Outdated
| @@ -26,7 +29,9 @@ | |||
| width: auto; | |||
| height: auto; | |||
| margin: 0; | |||
| overflow: visible; | |||
| overflow: visible; | |||
scss/mixins/_screen-reader.scss
Outdated
|
|
||
| @mixin sr-only { | ||
| position: absolute; | ||
| width: 1px; | ||
| height: 1px; | ||
| padding: 0; | ||
| margin: -1px; | ||
| overflow: hidden; | ||
| overflow: hidden; |
houndci-bot
reviewed
Mar 10, 2017
scss/mixins/_screen-reader.scss
Outdated
| @@ -26,7 +29,9 @@ | |||
| width: auto; | |||
| height: auto; | |||
| margin: 0; | |||
| overflow: visible; | |||
| overflow: visible; | |||
mdo
reviewed
Mar 18, 2017
scss/mixins/_screen-reader.scss
Outdated
| @@ -10,6 +11,8 @@ | |||
| margin: -1px; | |||
There was a problem hiding this comment.
Can we drop the margin: -1px? I don't see it in Hugo's post and I know we had an issue with it on GitHub causing a horizontal scrollbar with that.
|
Just removed the negative margin, which I forgot to remove before requesting pull (been testing multiple versions of this helper). I can't find any issue related to this but I'd be interested (I'll comment again if I find it). Thanks for reviewing! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small improvements that could be important:
clipis deprecated. Addingclip-pathas progressive enhancement; the shorter notation came from @ryuran 's suggestion;white-space.See the detailed post on Hugo Giraudel's blog.
Also kinda related to issue #20732 :)
Please let me know if you find any trouble with this technique. Thanks a lot!