Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update _screen-reader.scss #22154

Merged
merged 5 commits into from
Mar 19, 2017
Merged

Update _screen-reader.scss #22154

merged 5 commits into from
Mar 19, 2017

Commits on Mar 10, 2017

  1. Update _screen-reader.scss 

    Small improvements that could be important:
* `clip` [is deprecated](https://www.w3.org/TR/css-masking-1/#clip-property). Adding `clip-path` as progressive enhancement; the shorter notation came from @ryuran 's [suggestion](https://twitter.com/ryuran78/status/778943389819604992);
* [J. Renée Beach warned about single pixel with interfering with screen readers vocalisation](https://medium.com/@jessebeach/beware-smushed-off-screen-accessible-text-5952a4c2cbfe#.vcd5xlpgg) solved with `white-space`.

See [the detailed post on Hugo Giraudel's blog](http://hugogiraudel.com/2016/10/13/css-hide-and-seek/).

Also kinda related to issue #20732 :)

Please let me know if you find any trouble with this technique. Thanks a lot!
    @ffoodd
    ffoodd authored Mar 10, 2017
    Configuration menu
    Copy the full SHA
    5c144dc View commit details
    Browse the repository at this point in the history

  2. Reorder declarations 

    To pass Hound.
Didn't think `clip` and `clip-path` would be considered as unrelated…
    @ffoodd
    ffoodd authored Mar 10, 2017
    Configuration menu
    Copy the full SHA
    df8d86b View commit details
    Browse the repository at this point in the history

  3. Trailing spaces

    @ffoodd
    ffoodd authored Mar 10, 2017
    Configuration menu
    Copy the full SHA
    f836055 View commit details
    Browse the repository at this point in the history

  4. Last trailing space?

    @ffoodd
    ffoodd authored Mar 10, 2017
    Configuration menu
    Copy the full SHA
    2ff67fe View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2017

  1. Remove margin: -1px

    @ffoodd
    ffoodd authored Mar 19, 2017
    Configuration menu
    Copy the full SHA
    ca8320a View commit details
    Browse the repository at this point in the history