Make "Copy" buttons actual buttons #22445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfy1339
reviewed
Apr 14, 2017
docs/assets/js/src/application.js
Outdated
| $('.btn-clipboard').tooltip() | ||
| $('.btn-clipboard') | ||
| .tooltip() | ||
| .on('mouseleave', function (e) { |
There was a problem hiding this comment.
This argument is not needed, as it is not used anywhere. Because of that reason, tests are failing
There was a problem hiding this comment.
ah, you're right. good spot. removed and force-pushed an update
This makes them keyboard-accessible. For mouse users, the only change here is that the focus outline will remain on the button once clicked (in future, this can be solved with :focus-ring, but for now this would require a polyfill). the tooltip is explicitly hidden on `mouseleave`, so even though the `<button>` retains focus after clicking, the tooltip won't stay visible once mouse user moves away. the mouse hover styles have explicitly not been make to also apply to :focus, so as to minimise the visual impact for mouse users (though the tooltip remains visible) - but due to the default outline and the custom tooltip, it should be fairly clear when keyboard users set focus to a copy button too.
mdo
approved these changes
Apr 16, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes them keyboard-accessible.
For mouse users, the only change here is that the focus outline will remain on the button once clicked (in future, this can be solved with :focus-ring, but for now this would require a polyfill).
the tooltip is explicitly hidden on
mouseleave, so even though the<button>retains focus after clicking, the tooltip won't stay visible once mouse user moves away.the mouse hover styles have explicitly NOT been make to also apply to :focus, so as to minimise the visual impact for mouse users (though the browser's default outline will remain visible).