Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docsearch #22715

Closed
wants to merge 3 commits into from
Closed

add docsearch #22715

wants to merge 3 commits into from

Conversation

maxiloc
Copy link
Contributor

@maxiloc maxiloc commented May 28, 2017

Following my comment in #22711, I made this PR using the snippet I gave you so you can have
a look at how it looks.

zt79ksphmt

Happy to have your feedback on this.

@mdo mdo added this to the v4.0.0-beta milestone May 29, 2017
@mdo mdo mentioned this pull request May 29, 2017
5 tasks
@mdo
Copy link
Member

mdo commented May 29, 2017

Dope! Thanks for tackling this!

My only question is how can we hook this up so that it searches and navigates to the local docs when in development? I've grown quite accustomed to searching for pages when working on Bootstrap, and I imagine others might be confused when they jump to the production site. Any thoughts?

@maxiloc
Copy link
Contributor Author

maxiloc commented May 29, 2017

@mdo I updated the PR so the search also redirect correctly when in development mode.
Tell me if that works for you.

@mdo
Copy link
Member

mdo commented May 30, 2017

I cherry picked the commits from here and have them in #22716 now. Woot! Thanks so much @maxiloc. Let me know how I can help ensure the index stays up to date (I can add it to our shipping checklist). Also take a look at that PR—I've tweaked the design a bit and would love your input.

@maxiloc
Copy link
Contributor Author

maxiloc commented May 30, 2017

Hey I have just checked the new design of the search, I am having some style issues with the dropdown. Is that expected ? Happy to help on this if needed.

image

Regarding the updates of the index, what we can propose is to run a reindex every 30min, would that work for you ?

@mdo
Copy link
Member

mdo commented May 30, 2017

Hmm, I'm not seeing that in Chrome or Safari on my end. Do you have the latest dist files built?

@maxiloc
Copy link
Contributor Author

maxiloc commented May 30, 2017

I pulled again, I don't have that anymore.

@mdo
Copy link
Member

mdo commented Jun 1, 2017

Commits were cherry-picked into my other branch, which just merged, so we're good to go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants