Docs redesign #22716
Merged
Docs redesign #22716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's important, yo
since we're no longer using the .nav as a base class, we need to bring over some base styles for redoing browser list styles and setting flex in motion. also brings with it some .nav-link styling. we're still using this global class, but with this small modification for alignment of content in responsive modes.
- since we're column to start, need to set row. - note that flex-direction cannot be inherited, so we have to set it twice. - apply the horizontal padding again to .nav-link. - remove the .nav-item styles (un-needed). - remove previous .nav-link styles as they were un-nested and potentially problematic in old placement should someone mix more navs in here.
this was mad confusing for awhile
Closed
… into v4-docs-streamlined
- rename .btn-bs to .btn-bd-purple - abstract yellow masthead button into .btn-bd-yellow and use it the new docs navbar
… into v4-docs-streamlined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Been derping around on this one for awhile now. Finally feeling good about it to open the PR.
target="_blank"on social links in navbar