Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse of the color-yiq function #23191

Closed
wants to merge 2 commits into from
Closed

Reuse of the color-yiq function #23191

wants to merge 2 commits into from

Conversation

envolute
Copy link
Contributor

@envolute envolute commented Aug 1, 2017 •
edited by bardiharborow
Loading

Fixes #23114.

Reuse of the color-yiq function
2aa31e6 
This change refers to the issue twbs#23114
houndci-bot
houndci-bot reviewed Aug 1, 2017
View reviewed changes
scss/_functions.scss Outdated
@@ -49,17 +49,17 @@
}

// Color contrast
@mixin color-yiq($color) {
@mixin color-yiq($color, $prop: 'color') {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings

@gijsbotje gijsbotje mentioned this pull request Sep 13, 2017
Merged
@XhmikosR XhmikosR requested a review from mdo September 27, 2017 08:04
@mdo
Copy link
Member

mdo commented Oct 17, 2017

Punting on this one in favor of either #23748 or #23943. Thanks though!

@mdo mdo closed this Oct 17, 2017
@mdo mdo removed the on-hold label Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@mdo mdo Awaiting requested review from mdo

Assignees
No one assigned
Labels
css v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@envolute @mdo @houndci-bot @XhmikosR @bardiharborow