change yiq mixin to an actual function #23943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating fork of BS to v4-beta1
browsers-devices.md: fix typo. (twbs#23495)
update from official repo
update forked v4-dev
function only returns a value, not the attribute itself updated every use of the former mixin to use the new function
|
This is definitely something that has tripped me up - like the changes. |
mdo
approved these changes
Oct 4, 2017
|
@mdo are the hound-ci errors left really neccessary to be changed? |
|
Please ignore Hound until #24221 is merged and revert the patch. |
|
@gijsbotje: please revert your last patches. @mdo: did you see #23943 (comment)? |
|
@XhmikosR travis says |
|
@gijsbotje: that is right. You should address any Travis errors. |
XhmikosR
reviewed
Oct 4, 2017
scss/mixins/_badge.scss
Outdated
| text-decoration: none; | ||
| color: color-yiq($bg); |
|
@XhmikosR all done :) |
|
Cool, waiting for @mdo to choose which one of those related PRs we should merge, see #23943 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to me it seemed weird that this is a mixin that always returns the line
color: #xxx;i modified it to be an actual function and only return a value to be used in any property
also updated every use of the 'function' to use the actual function