Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove now unnecessary shrink-to-fit viewport directive #27818

Merged
merged 2 commits into from
Dec 15, 2018

Conversation

patrickhlauke
Copy link
Member

shrink-to-fit=no is not needed anymore - Apple removed the need for it from iOS9.3 onwards

See https://www.scottohara.me/blog/2018/12/11/shrink-to-fit.html and h5bp/html5-boilerplate#2102

/cc @scottaohara

`shrink-to-fit=no` is not needed anymore - Apple removed the need for it from iOS9.3 onwards

See https://www.scottohara.me/blog/2018/12/11/shrink-to-fit.html and h5bp/html5-boilerplate#2102
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@patrickhlauke patrickhlauke merged commit af484dc into v4-dev Dec 15, 2018
@mdo mdo mentioned this pull request Dec 15, 2018
@XhmikosR
Copy link
Member

I personally wouldn't have merged this just before 4.2. There was no hurry @patrickhlauke.

@XhmikosR XhmikosR deleted the v4-dev-remove-shrink-to-fit branch December 15, 2018 06:07
@XhmikosR XhmikosR restored the v4-dev-remove-shrink-to-fit branch December 16, 2018 00:08
@XhmikosR XhmikosR deleted the v4-dev-remove-shrink-to-fit branch December 16, 2018 00:08
XhmikosR added a commit that referenced this pull request Dec 16, 2018
XhmikosR added a commit that referenced this pull request Dec 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants