Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the now unneeded shrink-to-fit directive. #28314

Merged
merged 1 commit into from
Feb 27, 2019
Merged

Remove the now unneeded shrink-to-fit directive. #28314

merged 1 commit into from
Feb 27, 2019

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Feb 19, 2019 •
edited
Loading

Redo #27818.

shrink-to-fit=no is not needed anymore - Apple removed the need for it from iOS9.3 onwards

See https://www.scottohara.me/blog/2018/12/11/shrink-to-fit.html and h5bp/html5-boilerplate#2102

Do we plan to also bump the minimum iOS version @mdo?

Fixes #27861

@XhmikosR XhmikosR added the docs label Feb 19, 2019
@patrickhlauke
Copy link
Member

Do we plan to also bump the minimum iOS version @mdo?

we should, as 9.2 is ancient

@XhmikosR
Copy link
Member Author

Yeah, but this will happen in another PR where we address #28310 .

@XhmikosR XhmikosR added the v5 label Feb 19, 2019
@XhmikosR XhmikosR merged commit d5f9107 into master Feb 27, 2019
@XhmikosR XhmikosR deleted the master-xmr-rm-shrink-to-fit branch February 27, 2019 15:47
@rifaidev rifaidev mentioned this pull request Mar 17, 2019
Merged
@k-utsumi k-utsumi mentioned this pull request May 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bardiharborow bardiharborow bardiharborow approved these changes

@mdo mdo Awaiting requested review from mdo

@patrickhlauke patrickhlauke Awaiting requested review from patrickhlauke

Assignees
No one assigned
Labels
docs v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XhmikosR @patrickhlauke @bardiharborow