Drop color(), theme-color() & gray() functions
#29083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartijnCuppens
force-pushed
the
master-mc-cleanup-functions
branch
from
02b9c8b
to
363f39b
Compare
Should this function be renamed to |
Definitely |
MartijnCuppens
force-pushed
the
master-mc-cleanup-functions
branch
3 times, most recently
from
2d4b302
to
47ee60d
Compare
|
@ysds Yes, I would like to see that come back. The idea isn't to provide those classes to everyone though—just the variables and functions. The classes are purely there for docs presentation. |
|
@mdo OK, thanks 👍 @MartijnCuppens Can you confirm the changes in the |
|
Yup, it looks ok |
ysds
approved these changes
Jul 24, 2019
|
I just spotted some unwanted changes in |
…ables Also the `theme-color-level()` now accepts any color you want instead of only `$theme-color` colors.
MartijnCuppens
force-pushed
the
master-mc-cleanup-functions
branch
from
80514bd
to
526da87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop
color(),theme-color()&gray()functions in favor of variables. The functions just called amap-get()of a map where just the variables were defined.Also the
theme-color-level()now accepts any color you want instead of only$theme-colorscolors. The first value now is a variable instead of the$theme-colorskey.TODO:
theme-color-level()tocolor-level()https://deploy-preview-29083--twbs-bootstrap.netlify.com/docs/4.3/getting-started/theming/