-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] v5: Update colors to add shades and tints #28268
Conversation
Regarding tint and shade, if it ultimately works like a subset of @function tint-color($color, $level: 1) {
@return theme-color-level($color, $level);
}
@function shade-color($color, $level: 1) {
@return theme-color-level($color, - $level);
} |
The naming of the classes might be a bit confusing. |
@MartijnCuppens Once you use the system, it becomes familiar and recognizable. We do this at GitHub with Primer and it works out pretty well. I don't anticipate having all these as classes though inside the framework—those classes are just for docs. Variables should be available for everyone, and ideally there's a better way to generate those (but Sass doesn't do generated variables as I understand it), but for now it's manual. |
@mdo, I think we can better use the Utility API for this, this will give people more control over what classes are generated. People will probably also ask for responsive variants, which they can enable by simply setting |
Superseded by #29348. |
WIP, do not merge.
Exploring how to change up the mixins and adding multiple shades and tints to our colors for more flexibility. My hope is to at least restore some lighter variations to utilities like our
.bg-
options, but we'll likely keep the100
-900
variables as just variables and not classes.TODO: