use topiary's published crates over git #1919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannham
force-pushed
the
topiary-crates-io
branch
from
d1949a2
to
83b2915
Compare
|
Note: as this is required for 1.7, I'm also taking over this PR. Thanks for the scaffolding! |
yannham
reviewed
Jun 5, 2024
|
|
||
| report_progress "Pusing the release branch..." | ||
| git add RELEASES.md |
There was a problem hiding this comment.
This has been a long-standing bug for the release script unrelated to this PR (the missing git add), but each time I fix it and forgot to commit it to the master branch (given the branch juggling involved when doing a release), so I'm just taking the occasion.
Now that Topiary is published and crates.io (and tree-sitter-nickel as well), we move away from git revision and use proper public versions for those. Doing so, we can also crap the special casing that was done during release to disable those dependencies and we'll now be able to release on crates.io a version with formatting enabled. Co-authored-by: Yann Hamdaoui <[email protected]>
yannham
force-pushed
the
topiary-crates-io
branch
from
83b2915
to
5545fe0
Compare
yannham
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.