Update the release script #1952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the release script by adding some missing `git add`, which were lost when switching to using Topiary from crates.io. Doing so, we also remove the `--dry-run` step before publishing: the usual workflow is to perform the dry run test, and if it succeeds, immediately do the actual publication. This isn't very useful: if the dry run fails, we could have run the actual publication as well, which would have fail in the same way, so this makes no difference. However, if the dry run succeeds, we recompile each package one more time from scratch, performing the exact same work for publication, which is wasteful. At this point of the release script, we clearly intend to release and we should just use `cargo publish` normally.
jneem
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the release script by adding some missing
git add, which were lost when switching to using Topiary from crates.io (#1919).Doing so, we also remove the
--dry-runstep before publishing: the usual workflow is to perform the dry run test, and if it succeeds, immediately do the actual publication. This isn't very useful: if the dry run fails, we could have run the actual publication as well, which would have fail in the same way, so this makes no difference. However, if the dry run succeeds, we recompile each package one more time from scratch, performing the exact same work for the actualcargo publish, which is wasteful. At this point of the release script, we clearly intend to release and we should just usecargo publishdirectly.