Remote video view never showing. #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstraints main storyboard so the hangup button, identity label, and local video view will stay in their proper position regardless of screen size.
llSourcell
added a commit
that referenced
this pull request
Dec 23, 2015
Remote video view never showing.
paynerc
pushed a commit
that referenced
this pull request
Jun 12, 2019
Increment Twilio Common dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is one line missing from the file in the invite function where you get the conversation back from the invite, but the conversation delegate is never set and so the participant delegate never sets the remote video view.
There were also a few problems with the constraints. I adjusted the constraints for the local video view, identity label, and hangup button so they will stay in the position regardless of screen size and this also removed the constraint errors in IB.