refactor: long types and wchar_t cross-platform compatibility #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijsf
changed the title
This is necessary because unsigned long and long do not have sizes that are defined in the C spec, while some of the arithmetic done on it assumes 64-bit sizes.
…sewhere as this typedef may vary on some platforms.
ijsf
force-pushed
the
refactor/win32_longs
branch
from
42d8f48
to
17bb7ac
Compare
|
I've cleaned up this PR. All tests are passing now.
|
|
After careful consideration, I would like to reject this pull request because it is difficult for me to support the MinGW64 platform. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirement for #156.
This seems to be one of the more invasive changes necessary.
unsigned long,long,uintptr_tandintptr_tdo not have sizes that are explicitly defined in the C spec, while some of the arithmetic done on it assumes 64-bit sizes. The pointer types have been replaced with typedefs, and all of these types ultimately resolve to long long or stdint types now.wchar_tis now explicitly a 32-bit integer inside the compiler.