feat: Win32 compatibility for wcc (MinGW64 MSYS) #159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary because unsigned long and long do not have sizes that are defined in the C spec, while some of the arithmetic done on it assumes 64-bit sizes.
…sewhere as this typedef may vary on some platforms.
…S toolchain. Tests test-wcc, test-wcc-gen2 are passing on Win32. xcc compiled but does not currently work because it has less purpose on Win32.
ijsf
changed the title
|
All tests pass. Ideally there should be no regression on POSIX platforms. |
|
After careful consideration, I would like to reject this pull request because it is difficult for me to support the MinGW64 platform. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #156.
Requires MinGW64 MSYS as toolchain.
Notes:
longtypes are 32-bit, not 64-bit on Win32).ar.handgetline.h.platform.candplatform.h.Passes
test-wccandtest-wcc-gen2tests on Win32.