Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lift method for WriterT #1315

Closed
labra opened this issue Aug 22, 2016 · 1 comment
Closed

lift method for WriterT #1315

labra opened this issue Aug 22, 2016 · 1 comment

Comments

@labra
Copy link
Contributor

labra commented Aug 22, 2016

There is no lift method in WriterT while there is a lift method in StateT and ReaderT. It would be better to have a more unified API for users.

I also noticed that there is a liftT method but its signature requires a two parameter type that makes it more difficult to understand
labra added a commit to labra/cats that referenced this issue Aug 23, 2016
@labra
Attempt to solve typelevel#1315
e9d768e
labra added a commit to labra/cats that referenced this issue Aug 23, 2016
@labra
Attempt to solve typelevel#1315
0dc8eb7
@labra
Copy link
Contributor Author

labra commented Aug 23, 2016 •
edited
Loading

I have done a first attempt to add the liftTmethod to WriterT following the StateT code in this PR

johnynek pushed a commit that referenced this issue Aug 23, 2016
@labra @johnynek
Added liftT to WriterT (issue #1315) (#1325)
7feff3e 
* Attempt to solve #1315

* Attempt to solve #1315
@johnynek johnynek reopened this Aug 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnynek @labra