Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added liftT to WriterT (issue #1315) #1325

Merged
merged 2 commits into from
Aug 23, 2016
Merged

Conversation

labra
Copy link
Contributor

@labra labra commented Aug 23, 2016

I added the liftT method to the companion object of WriterT following the StateT style. I also added a test and it seems to pass locally.

This is my first PR to cats so it probably needs some reviews. Anyway, the code added is minimal...

@labra labra mentioned this pull request Aug 23, 2016
@codecov-io
Copy link

Current coverage is 91.53% (diff: 100%)

Merging #1325 into master will increase coverage by 0.05%

@@             master      #1325   diff @@
==========================================
  Files           234        234          
  Lines          3543       3542     -1   
  Methods        3484       3483     -1   
  Messages          0          0          
  Branches         59         59          
==========================================
+ Hits           3241       3242     +1   
+ Misses          302        300     -2   
  Partials          0          0          

Sunburst

Powered by Codecov. Last update 06539fa...0dc8eb7

@non
Copy link
Contributor

non commented Aug 23, 2016

LGTM 👍

Thanks!

@johnynek
Copy link
Contributor

👍

@johnynek johnynek merged commit 7feff3e into typelevel:master Aug 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants