Added liftT to WriterT (issue #1315) #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 91.53% (diff: 100%)@@ master #1325 diff @@
==========================================
Files 234 234
Lines 3543 3542 -1
Methods 3484 3483 -1
Messages 0 0
Branches 59 59
==========================================
+ Hits 3241 3242 +1
+ Misses 302 300 -2
Partials 0 0
|
|
LGTM 👍 Thanks! |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the
liftTmethod to the companion object ofWriterTfollowing theStateTstyle. I also added a test and it seems to pass locally.This is my first PR to cats so it probably needs some reviews. Anyway, the code added is minimal...